Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Merge branch 'release/9.0.1xx' => 'release/9.0.2xx' #45993

Merged
merged 78 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
e6c1ca7
Create Subdirectory for Temp Deps.Json File. Please contact me for fu…
nagilson Nov 5, 2024
f4ebb83
Avoid warning about empty NuGetPackageRoot in wpftmp projects
jjonescz Nov 6, 2024
4b54daf
Fix a typo in a comment
jjonescz Nov 8, 2024
802c364
Merged PR 44657: Create Subdirectory for Temp Deps.Json File.
nagilson Nov 27, 2024
83b9bac
Merge commit 'd281819115c3f8590b6eb53f7cf12c6d692af8d3'
Nov 27, 2024
a6880e7
Merge commit '18bb77155d4515bea9142f27594c01abf4e065fb'
Nov 27, 2024
f700962
Merge commit 'b0ed0bc28bf85e579018b38db5cd01a11c66b67a'
Nov 28, 2024
a9461db
Merge commit '5040911b098b7588b9631a47320a24e4dc427e63'
Nov 28, 2024
7a3ae21
Merge commit '9a36fabd49f20312120e12b80da85f6af02f9168'
Nov 28, 2024
cb76eb6
Merge commit '622c5ac795b819a4694ac817ed5abb9e60b91c7e'
Nov 29, 2024
67ab546
Merge commit 'cbec38b13edc53f701225f8f087fb5a2dbfd3679'
Nov 29, 2024
f4005f4
Merge commit 'cab7c0aa385e934bb82d65d3b04bc780b975d6bc'
Dec 2, 2024
c333482
Merge commit '1010c375303c0f2e7f38e290f721b53c8908cde4'
Dec 3, 2024
814c043
Merge commit 'b811627f43c503fb6a6d69d0ce3653c1649327af'
Dec 3, 2024
df208c4
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Dec 4, 2024
048f66b
Merge commit 'a9735335a2d805c005239027b0912a59fa470729'
Dec 4, 2024
7d3cea8
Merge commit '063b86a7fb12fb5a9d8d17c13cfd9255143cc254'
Dec 4, 2024
32d234a
Merged PR 45646: [internal/release/9.0.1xx] Update dependencies from …
Dec 4, 2024
3560990
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Dec 4, 2024
7aba192
Merged PR 45672: [internal/release/9.0.1xx] Update dependencies from …
Dec 4, 2024
ed05d81
Merge commit 'ce61561e9449a4ac7196ef7e2e5b5e6ef0f56c1c'
Dec 5, 2024
ac1018f
Merge commit '53e76267e55824c75e2501d6cae156bb4b1529ed'
Dec 5, 2024
ee6a289
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Dec 5, 2024
0528d50
Merge commit '9d448155a70cbea5b9f2c88d8bdf51dedc29b297'
Dec 5, 2024
2c61b15
Merge commit 'bd3ac8403574415c85cf3cf2125828bc2dfe15d2'
Dec 5, 2024
33fefd6
Merge commit 'f34203e9ae247a0100f0f4e56d84ad97d4e08a17'
Dec 5, 2024
925a4b9
Merged PR 45676: [internal/release/9.0.1xx] Update dependencies from …
Dec 5, 2024
75ccf13
Force timeouts
marcpopMSFT Dec 5, 2024
ecb6e10
Find where the blame dump is saved to
marcpopMSFT Dec 5, 2024
7d28a22
Merge commit 'd18ddf7b9bd42a0c5537eab8eb396b9340bf6d88'
Dec 6, 2024
357543a
Merge commit '92d3e8bae1b2c04b64cb333fb78b5294fa32731a'
Dec 6, 2024
83fdde5
lower the threshold to try to force a timeout
marcpopMSFT Dec 6, 2024
3514d70
Trying copying the dump files to the helix work item upload folder
marcpopMSFT Dec 6, 2024
877e63a
Set the per test timeout to 15 minutes so we get a dump if there is a…
marcpopMSFT Dec 9, 2024
d7d6de5
Merge commit 'a345a00343aa14a693aec75a3d56fc07e99e517f'
Dec 10, 2024
c172074
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Dec 11, 2024
ff52b0a
Merged PR 45859: [internal/release/9.0.1xx] Update dependencies from …
Dec 11, 2024
e38ff25
Merged PR 45862: [internal/release/9.0.1xx] Update dependencies from …
Dec 11, 2024
02a158e
Merged PR 45866: [internal/release/9.0.1xx] Update dependencies from …
Dec 11, 2024
78b7bd9
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Dec 11, 2024
cb83cd4
Merged PR 45867: [internal/release/9.0.1xx] Update dependencies from …
Dec 11, 2024
f3ad3e7
Add a dotnet test diag log file
marcpopMSFT Dec 12, 2024
0cc58a2
Switch to Path.Combine since join is not supported on framework
marcpopMSFT Dec 13, 2024
ff0709d
Switch to using the environment variable directly in the CLI call
marcpopMSFT Dec 16, 2024
55dd1f3
Merge branch 'release/9.0.1xx' into marcpopMSFT-copydmptooutput
marcpopMSFT Dec 16, 2024
505a500
clean up the code. Remove the -- if there are no arguments.
marcpopMSFT Dec 18, 2024
7032fbb
[FIX] tool-update: Compare tool versions correctly
edvilme Oct 29, 2024
2e18ef4
[TEST] tool-update: Update same version different release tag
edvilme Oct 30, 2024
8c07f4f
Fix tests
edvilme Oct 30, 2024
ffd8f75
[release/8.0.3xx] Update dependencies from dotnet/source-build-extern…
dotnet-maestro[bot] Jan 11, 2025
d83d7e6
Update dependencies from /~https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Jan 11, 2025
790769d
Update dependencies from /~https://github.com/dotnet/source-build-exter…
dotnet-maestro[bot] Jan 11, 2025
10c21e5
Update dependencies from /~https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Jan 11, 2025
6973e2b
[release/8.0.3xx] Update dependencies from dotnet/arcade (#45893)
v-wuzhai Jan 13, 2025
69ab1bf
[release/8.0.3xx] Update dependencies from dotnet/source-build-extern…
v-wuzhai Jan 13, 2025
cf91715
[release/8.0.3xx] Update dependencies from dotnet/source-build-refere…
v-wuzhai Jan 13, 2025
c6e02fd
Merge branch 'release/8.0.4xx' of /~https://github.com/dotnet/sdk into …
v-wuzhai Jan 13, 2025
f408834
Update dependencies from /~https://github.com/dotnet/templating build 2…
dotnet-maestro[bot] Jan 13, 2025
55f34d4
[release/8.0.4xx] Update dependencies from dotnet/templating (#45921)
v-wuzhai Jan 13, 2025
8634d6a
[automated] Merge branch 'release/8.0.3xx' => 'release/8.0.4xx' (#45911)
v-wuzhai Jan 13, 2025
fd425d7
Add posix dmp copy command (#45704)
Forgind Jan 8, 2025
0d3149e
Merge commit 'cb83cd4923f0973ae11dfb5602737493bf165210' into internal…
vseanreesermsft Jan 14, 2025
141d487
Copy dump file to the Helix upload location (#45345)
marcpopMSFT Jan 14, 2025
c7b56da
[9.0.1xx] Avoid warning about empty NuGetPackageRoot in wpftmp projec…
marcpopMSFT Jan 14, 2025
6eeea6c
[release/9.0.1xx] Backport "Pin Base Image via Digest" to release/9.0…
github-actions[bot] Jan 14, 2025
1511796
Update dependencies from dotnet/deployment-tools
joeloff Jan 14, 2025
8348846
Update dependencies from dotnet/deployment-tools (#45972)
joeloff Jan 15, 2025
c6e099f
Merge branch 'release/9.0.1xx' of /~https://github.com/dotnet/sdk into …
v-wuzhai Jan 15, 2025
e60ca75
[automated] Merge branch 'release/8.0.4xx' => 'release/9.0.1xx' (#45985)
v-wuzhai Jan 15, 2025
a5b3141
[release/9.0.1xx] [FIX] tool-update: Compare tool versions correctly …
marcpopMSFT Jan 15, 2025
ad1bda1
Merging internal commits for release/9.0.1xx (#45962)
marcpopMSFT Jan 15, 2025
f69e892
.NET Source-Build 9.0.102 January 2025 Updates (#45967)
dotnet-sb-bot Jan 15, 2025
049799c
Update OmniSharp version used by source build tests (#46005)
ellahathaway Jan 15, 2025
aa9b2be
Merge remote-tracking branch 'upstream/release/9.0.2xx' into HEAD
nagilson Jan 15, 2025
5645803
Remove extra command
nagilson Jan 15, 2025
2459b35
skip failing test - see /~https://github.com/dotnet/sdk/issues/46006
nagilson Jan 16, 2025
7c21283
Merge remote-tracking branch 'upstream/merge/release/9.0.1xx-to-relea…
nagilson Jan 16, 2025
4909403
Remove test templates : see from @/marcpopMSFT that those should not …
nagilson Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ internal void GenerateDepsJsonFile(
LocalizableStrings.GeneratingDepsJson,
depsPath));

var tempDepsFile = Path.GetTempFileName();
var tempDepsFile = Path.Combine(PathUtilities.CreateTempSubdirectory(), Path.GetRandomFileName());

var args = new List<string>();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ private NuGetVersion GetBestMatchNugetVersion(PackageId packageId, VersionRange

private static bool ToolVersionAlreadyInstalled(IToolPackage oldPackageNullable, NuGetVersion nuGetVersion)
{
return oldPackageNullable != null && (oldPackageNullable.Version.Version == nuGetVersion.Version);
return oldPackageNullable != null && (oldPackageNullable.Version == nuGetVersion);
}

private static void EnsureVersionIsHigher(IToolPackage oldPackageNullable, IToolPackage newInstalledPackage, bool allowDowngrade)
Expand Down
4 changes: 2 additions & 2 deletions src/SourceBuild/content/eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
<ProductDependencies>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="9.0.0-beta.24516.2">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="9.0.0-beta.24572.2">
<Uri>/~https://github.com/dotnet/arcade</Uri>
<Sha>3c393bbd85ae16ddddba20d0b75035b0c6f1a52d</Sha>
<Sha>b41381d5cd633471265e9cd72e933a7048e03062</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
4 changes: 2 additions & 2 deletions src/SourceBuild/content/eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
of a .NET major or minor release, prebuilts may be needed. When the release is mature, prebuilts
are not necessary, and this property is removed from the file.
-->
<PrivateSourceBuiltSdkVersion>9.0.101</PrivateSourceBuiltSdkVersion>
<PrivateSourceBuiltArtifactsVersion>9.0.101-servicing.24575.1</PrivateSourceBuiltArtifactsVersion>
<PrivateSourceBuiltSdkVersion>9.0.102</PrivateSourceBuiltSdkVersion>
<PrivateSourceBuiltArtifactsVersion>9.0.102-servicing.24611.1</PrivateSourceBuiltArtifactsVersion>
<!-- command-line-api dependencies -->
<SystemCommandLineVersion>2.0.0-beta4.24126.1</SystemCommandLineVersion>
<!-- msbuild dependencies -->
Expand Down
4 changes: 2 additions & 2 deletions src/SourceBuild/content/global.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"tools": {
"dotnet": "9.0.101"
"dotnet": "9.0.102"
},
"msbuild-sdks": {
"Microsoft.Build.NoTargets": "3.7.0",
"Microsoft.Build.Traversal": "3.4.0",
"Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24516.2"
"Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24572.2"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Microsoft.DotNet.SourceBuild.SmokeTests;
public class OmniSharpTests : SdkTests
{
// Update version as new releases become available: /~https://github.com/OmniSharp/omnisharp-roslyn/releases
private const string OmniSharpReleaseVersion = "1.39.12";
private const string OmniSharpReleaseVersion = "1.39.13";

private string OmniSharpDirectory { get; } = Path.Combine(Directory.GetCurrentDirectory(), nameof(OmniSharpTests));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public override bool Execute()

/// <summary>
/// The asynchronous execution method for this MSBuild task which verifies the integrity of required properties
/// and validates their formatting, specifically determining whether the provided xUnit project data have a
/// and validates their formatting, specifically determining whether the provided xUnit project data have a
/// one-to-one mapping. It then creates this mapping before asynchronously preparing the HelixWorkItem TaskItem
/// objects via the PrepareWorkItem method.
/// </summary>
Expand Down Expand Up @@ -148,11 +148,13 @@ private async Task<List<ITaskItem>> PrepareWorkItem(ITaskItem xunitProject)
var partitionedWorkItem = new List<ITaskItem>();
foreach (var assemblyPartitionInfo in assemblyPartitionInfos)
{
string command;
string enableDiagLogging = IsPosixShell ? "-d $HELIX_WORKITEM_UPLOAD_ROOT//dotnetTestLog.log" : "-d %HELIX_WORKITEM_UPLOAD_ROOT%\\dotnetTestLog.log";
arguments = string.IsNullOrEmpty(arguments) ? "" : "-- " + arguments;

var testFilter = string.IsNullOrEmpty(assemblyPartitionInfo.ClassListArgumentString) ? "" : $"--filter \"{assemblyPartitionInfo.ClassListArgumentString}\"";
command = $"{driver} test {assemblyName} -e HELIX_WORK_ITEM_TIMEOUT={timeout} {testExecutionDirectory} {msbuildAdditionalSdkResolverFolder} " +
$"{(XUnitArguments != null ? " " + XUnitArguments : "")} --results-directory .{Path.DirectorySeparatorChar} --logger trx --logger \"console;verbosity=detailed\" --blame-hang --blame-hang-timeout 15m {testFilter} -- {arguments}";

string command = $"{driver} test {assemblyName} -e HELIX_WORK_ITEM_TIMEOUT={timeout} {testExecutionDirectory} {msbuildAdditionalSdkResolverFolder} " +
$"{(XUnitArguments != null ? " " + XUnitArguments : "")} --results-directory .{Path.DirectorySeparatorChar} --logger trx --logger \"console;verbosity=detailed\" --blame-hang --blame-hang-timeout 15m {testFilter} {enableDiagLogging} {arguments}";

Log.LogMessage($"Creating work item with properties Identity: {assemblyName}, PayloadDirectory: {publishDirectory}, Command: {command}");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public GivenThatWeWantToPublishAnAotApp(ITestOutputHelper log) : base(log)
{
}

[RequiresMSBuildVersionTheory("17.12.0")]
[RequiresMSBuildVersionTheory("17.12.0", Skip = "/~https://github.com/dotnet/sdk/issues/46006")]
[MemberData(nameof(Net7Plus), MemberType = typeof(PublishTestUtils))]
public void NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled(string targetFramework)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,21 @@ public void GivenAnExistedLowerversionInstallationWhenUpdateAllItCanPrintSuccess
_packageId, LowerPackageVersion, HigherPackageVersion));
}

[Fact]
public void GivenAnExistedPreviewVersionInstallationWhenUpdateToHigherVersionItSucceeds()
{
var installCommand = CreateInstallCommand($"-g {_packageId} --version {HigherPreviewPackageVersion} --verbosity minimal");
installCommand.Execute();
_reporter.Lines.Clear();

var command = CreateUpdateCommand($"-g {_packageId} --version {HigherPackageVersion} --verbosity minimal");
command.Execute().Should().Be(0);

_reporter.Lines.First().Should().Contain(string.Format(
LocalizableStrings.UpdateSucceeded,
_packageId, HigherPreviewPackageVersion, HigherPackageVersion));
}

[Fact]
public void GivenAnExistedHigherversionInstallationWhenUpdateToLowerVersionItErrors()
{
Expand Down
Loading