Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce System.Runtime.TieredPGO knob #26350

Merged
merged 6 commits into from
Jul 12, 2022
Merged

Introduce System.Runtime.TieredPGO knob #26350

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94b4e23
Add <TieredPGO>true</TieredPGO>
EgorBo Jun 29, 2022
db55d95
Merge branch 'main' of github.com:dotnet/sdk into add-tieredpgo
EgorBo Jul 6, 2022
7d04c4a
Merge branch 'main' of github.com:dotnet/sdk into add-tieredpgo
EgorBo Jul 10, 2022
3a276f4
clean up
EgorBo Jul 10, 2022
df62ad9
clean up
EgorBo Jul 10, 2022
01b19d6
Add a test
EgorBo Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,10 @@ Copyright (c) .NET Foundation. All rights reserved.
Condition="'$(TieredCompilationQuickJitForLoops)' != ''"
Value="$(TieredCompilationQuickJitForLoops)" />

<RuntimeHostConfigurationOption Include="System.Runtime.TieredPGO"
Condition="'$(TieredPGO)' != ''"
Value="$(TieredPGO)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is PGO the term we use in docs when discussing this feature with customers? These strings System.Runtime.TieredPGO and TieredPGO are basically public APIs, so we have to be happy with the names we are picking here. It would be a breaking change to rename them later.

Copy link
Member Author

@EgorBo EgorBo Jul 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eerhardt We've been advertising DOTNET_TieredPGO environment variable since .NET 6.0 e.g.
https://devblogs.microsoft.com/dotnet/announcing-net-6/#dynamic-pgo (I was collecting feedback from users here: https://gist.github.com/EgorBo/dc181796683da3d905a5295bfd3dd95b) - it perfectly aligns with DOTNET_TieredCompilation which maps to <TieredCompilation>true</TieredCompilation> here.

We considered other names/options but a simple boolean property seems to be the best and simple. Eventually, we plan to enable it by default I guess (e.g. in .NET 8.0). For .NET 7.0 we just want our customers to be able to easily enable it to try the feature


<RuntimeHostConfigurationOption Include="System.StartupHookProvider.IsSupported"
Condition="'$(StartupHookSupport)' != ''"
Value="$(StartupHookSupport)"
Expand Down