Add EnableAotAnalyzer support into SDK #24091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set EnableAotAnalyzer if PublishAot is set - Import Microsoft.NET.ILLink.Analyzers.props if EnableAotAnalyzer is set - Import ILLink Analyzers if EnableAotAnalyzer is set Add tests in SDK
tlakollo
requested review from
agocke,
sbomer,
LakshanF and
MichalStrehovsky
|
I'm creating this as a draft since when solving issues in the tests I realized that I needed to fix dotnet/linker#2650 and dotnet/linker#2655. Now I need to wait for those changes to flow into SDK otherwise the tests will fail. |
sbomer
reviewed
Feb 25, 2022
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets
Outdated
Show resolved
Hide resolved
…rent for every test
sbomer
approved these changes
Feb 26, 2022
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
Outdated
Show resolved
Hide resolved
… another test file Use LatestTFM for now, eventually it should be Dotnet7Plus
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add EnableAotAnalyzer support into SDK
Add tests in SDK