Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][non-icu] HybridGlobalization implement timezoneinfo functions #91458

Merged
merged 15 commits into from
Sep 7, 2023
Merged

[iOS][non-icu] HybridGlobalization implement timezoneinfo functions #91458

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7aa7289
Initial changed for timezone hybrid mode
mkhamoyan Aug 31, 2023
cfd0f5b
Refactoring
mkhamoyan Sep 1, 2023
3678a48
Fix test failure on ios
mkhamoyan Sep 1, 2023
8cf5609
Fix wasm build failure
mkhamoyan Sep 1, 2023
b44508f
Fix wasm build
mkhamoyan Sep 1, 2023
21acbca
Fix wasm build
mkhamoyan Sep 1, 2023
4947b49
Minor fix
mkhamoyan Sep 1, 2023
32e90d8
Remove logging
mkhamoyan Sep 1, 2023
88088d8
Fix failure on maccatalyst
mkhamoyan Sep 5, 2023
f187abb
Merge branch 'main' into hybrid_timezone_changes
mkhamoyan Sep 5, 2023
a886791
Changed displayName for hybrid mode
mkhamoyan Sep 5, 2023
8d91430
Remove logs
mkhamoyan Sep 5, 2023
4d9b1f6
Changes requested by review
mkhamoyan Sep 6, 2023
a64ee2b
Fix build failure
mkhamoyan Sep 6, 2023
c589bbe
Add checks and remove not needed code
mkhamoyan Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test failure on ios
  • Loading branch information
@mkhamoyan
mkhamoyan committed Sep 1, 2023
commit 3678a4869a4e74d0757b9cd26ee62ea458b3f73e
10 changes: 10 additions & 0 deletions src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,16 @@ public static IEnumerable<object[]> Platform_TimeZoneNamesTestData()
{ s_NewfoundlandTz, "(UTC-03:30) America/St_Johns", null, "NST", "NDT" },
{ s_catamarcaTz, "(UTC-03:00) America/Argentina/Catamarca", null, "-03", "-02" }
};
else if(PlatformDetection.IsHybridGlobalizationOnOSX && (PlatformDetection.IsiOS || PlatformDetection.IstvOS))
return new TheoryData<TimeZoneInfo, string, string, string, string>
{
{ TimeZoneInfo.FindSystemTimeZoneById(s_strPacific), "(UTC-08:00) America/Los_Angeles", null, "Pacific Standard Time", "Pacific Daylight Time" },
{ TimeZoneInfo.FindSystemTimeZoneById(s_strSydney), "(UTC+10:00) Australia/Sydney", null, "Australian Eastern Standard Time", "Australian Eastern Daylight Time" },
{ TimeZoneInfo.FindSystemTimeZoneById(s_strPerth), "(UTC+08:00) Australia/Perth", null, "Australian Western Standard Time", "Australian Western Daylight Time" },
{ TimeZoneInfo.FindSystemTimeZoneById(s_strIran), "(UTC+03:30) Asia/Tehran", "(UTC+03:30) Iran Standard Time (Tehran)", "Iran Standard Time", "Iran Daylight Time" },
{ s_NewfoundlandTz, "(UTC-03:30) America/St_Johns", null, "Newfoundland Standard Time", "Newfoundland Daylight Time" },
{ s_catamarcaTz, "(UTC-03:00) America/Argentina/Catamarca", null, "Argentina Standard Time", "Argentina Summer Time" }
};
else if (PlatformDetection.IsWindows)
return new TheoryData<TimeZoneInfo, string, string, string, string>
{
Expand Down