-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows based ECDSA SignedCms #91183
Conversation
Supports SignedCms signatured with an ECDSA key created by the Windows API or .NET Framework. These signatures store an EC public key OID rather than a hash specific ECDSA OID used in newer versions of dotnet. Fixes dotnet#77377
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsSupports SignedCms signatured with an ECDSA key created by the Windows API or .NET Framework. These signatures store an EC public key OID rather than a hash specific ECDSA OID used in newer versions of dotnet. Fixes #77377
|
Huh. I thought there was a digest / canonicalization issue somewhere too, but now that I try to reproduce that, I can't. So these changes alone seem good (and we have a passing test to prove it). |
Thanks for the review. Is it possible to get this in for |
/cc @jeffhandley a customer request for a backport for .NET 8. It's a pretty small change and straightforward with no complexity. Justification being that it improves upgrade compatibility from .NET Framework. |
/backport to release/8.0 This has my support for .NET 8 RC2. It's fixing a bug that hinders compatibility between .NET Framework and .NET Core and a fix will aid customers going through that migration. It's customer-reported with an expressed need for the backport. |
Started backporting to release/8.0: /~https://github.com/dotnet/runtime/actions/runs/6006136859 |
Supports SignedCms signatured with an ECDSA key created by the Windows API or .NET Framework. These signatures store an EC public key OID rather than a hash specific ECDSA OID used in newer versions of dotnet.
Fixes #77377