Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows based ECDSA SignedCms #91183

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

jborean93
Copy link
Contributor

Supports SignedCms signatured with an ECDSA key created by the Windows API or .NET Framework. These signatures store an EC public key OID rather than a hash specific ECDSA OID used in newer versions of dotnet.

Fixes #77377

Supports SignedCms signatured with an ECDSA key created by the Windows
API or .NET Framework. These signatures store an EC public key OID
rather than a hash specific ECDSA OID used in newer versions of dotnet.

Fixes dotnet#77377
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 27, 2023
@ghost
Copy link

ghost commented Aug 27, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Supports SignedCms signatured with an ECDSA key created by the Windows API or .NET Framework. These signatures store an EC public key OID rather than a hash specific ECDSA OID used in newer versions of dotnet.

Fixes #77377

Author: jborean93
Assignees: -
Labels:

area-System.Security, community-contribution

Milestone: -

@vcsjones
Copy link
Member

Huh. I thought there was a digest / canonicalization issue somewhere too, but now that I try to reproduce that, I can't. So these changes alone seem good (and we have a passing test to prove it).

@vcsjones vcsjones merged commit 602db78 into dotnet:main Aug 28, 2023
@jborean93 jborean93 deleted the win-ecdsa-sig branch August 28, 2023 22:18
@jborean93
Copy link
Contributor Author

jborean93 commented Aug 28, 2023

Thanks for the review. Is it possible to get this in for net8, if so what would be the process? Would be great to have the changes as part of that LTS release especially now that ECDSA signatures will be more prevalent.

@vcsjones
Copy link
Member

vcsjones commented Aug 28, 2023

/cc @jeffhandley a customer request for a backport for .NET 8. It's a pretty small change and straightforward with no complexity. Justification being that it improves upgrade compatibility from .NET Framework.

@jeffhandley
Copy link
Member

/backport to release/8.0

This has my support for .NET 8 RC2. It's fixing a bug that hinders compatibility between .NET Framework and .NET Core and a fix will aid customers going through that migration. It's customer-reported with an expressed need for the backport.

@github-actions
Copy link
Contributor

Started backporting to release/8.0: /~https://github.com/dotnet/runtime/actions/runs/6006136859

@jeffhandley
Copy link
Member

@krwq or @vcsjones -- could one of you fill in the backport PR template when it's ready please?

@vcsjones
Copy link
Member

@krwq or @vcsjones -- could one of you fill in the backport PR template when it's ready please?

Done.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cms signature created with .Net Framework cannot be verified with .Net Core for an elliptic curve certificate
3 participants