Fix duplicate asset because of "Build tools subset to generate artifacts" #80487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
cc @tlakollo |
ViktorHofer
force-pushed
the
revert-80406-BuildToolsAlongLibraries
branch
from
f6ce154 to
448d30f
Compare
ghost
added
the
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr Issue DetailsReverts #80406 Broke official builds because the illink package was uploaded in every leg instead of just on windows_x64
|
akoeplinger
approved these changes
Jan 11, 2023
ViktorHofer
changed the title
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a1bfa04 broke official builds because the illink package was uploaded in every leg instead of just on windows_x64
I first wanted to revert the change but decided to fix it instead as the fix is straightforward. Setting
GeneratePackageOnBuildresults in the package being created and published in every RID leg. The dnceng public asset promotion pipeline doesn't allow duplicate assets and hence the official build failed.Unfortunately we don't have any CI protection for that and we actually hit that issue multiple times in the past cc @mmitche.
Resolving the issue by removing the
GeneratePackageOnBuildsetting and instead letting packaging.targets define it whenBuildAllConfigurations=trueis passed in (which is only true in an official build for windows-x64).