Move linker to runtime #77149
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| ### Code Style Analyzers | ||
|
There was a problem hiding this comment. Can we delete this and use repo-wide global configurations ( There was a problem hiding this comment. This already takes into account the CodeAnalysis.{src,test}.globalconfig. This is an override of what's in that file. For example, IDE0005 is not enabled globally because a lot of the files in the runtime have |
||
|
|
||
| [*.cs] | ||
| # IDE0005: Remove unnecessary usings/imports | ||
| dotnet_diagnostic.IDE0005.severity = error | ||
|
|
||
| # IDE0073: Require file header | ||
| dotnet_diagnostic.IDE0073.severity = warning | ||
|
|
||
| # IL3000: Avoid accessing Assembly file path when publishing as a single file | ||
| dotnet_diagnostic.IL3000.severity = suggestion | ||
|
|
||
| # CS0176: Cannot be accessed with an instance ref | ||
| dotnet_diagnostic.CS0176.severity = silent | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <IsReferenceAssembly Condition="'$(IsReferenceAssembly)' == '' and '$([System.IO.Path]::GetFileName($(MSBuildProjectDirectory)))' == 'ref'">true</IsReferenceAssembly> | ||
| <DisableImplicitNamespaceImports_DotNet>true</DisableImplicitNamespaceImports_DotNet> | ||
| <!-- The TFM for the product (linker, task,.. not analyzer, which is netstandard) --> | ||
| <NetCoreAppToolCurrent>net7.0</NetCoreAppToolCurrent> | ||
| <!-- The TFM for all the tests - intentionally different since tests may depend on new framework APIs in order to validate | ||
| linker interaction with them, linker itself doesn't need the new framework typically. --> | ||
| <NetCoreAppTestsCurrent>net7.0</NetCoreAppTestsCurrent> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(IsReferenceAssembly)' == 'true' "> | ||
| <!-- Since .NET 5 reference assemblies are always produced --> | ||
| <ProduceReferenceAssembly>false</ProduceReferenceAssembly> | ||
| <ProduceOnlyReferenceAssembly>true</ProduceOnlyReferenceAssembly> | ||
| <!-- Used by Arcade to compute OutputPath, IntermediateOutputPath, etc. early in the import chain. --> | ||
| <OutDirName>$(MSBuildProjectName)/ref</OutDirName> | ||
| <!-- Don't try to publish PDBs for ref assemblies that have none. --> | ||
| <PublishWindowsPdb>false</PublishWindowsPdb> | ||
| <RunApiCompat>false</RunApiCompat> | ||
| </PropertyGroup> | ||
|
|
||
| <Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" /> | ||
| <Import Project="eng/Analyzers.props" /> | ||
| <PropertyGroup> | ||
| <IsPackable>false</IsPackable> | ||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| <RepositoryUrl>/~https://github.com/dotnet/linker</RepositoryUrl> | ||
| <!-- Set this to true to build against the package instead of the submodule. --> | ||
| <UseCecilPackage Condition="'$(UseCecilPackage)' == ''">true</UseCecilPackage> | ||
| <!-- No symbols are produced for ref assemblies, but some parts of the SDK still expect pdbs, so we explicitly tell it there are none. --> | ||
| <!-- Must be set after importing Arcade to override its defaults. --> | ||
| <DebugType Condition=" '$(IsReferenceAssembly)' == 'true' ">none</DebugType> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <LangVersion>preview</LangVersion> | ||
| <AnalysisLevel>latest</AnalysisLevel> | ||
| </PropertyGroup> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| <Project> | ||
| <Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" /> | ||
|
|
||
| <Import Project="$(_ToolsProjectTargets)" Condition="Exists('$(_ToolsProjectTargets)')" /> | ||
|
|
||
| <Target Name="VSTestIfTestProject"> | ||
| <CallTarget Targets="VSTest" Condition="'$(IsTestProject)' == 'true'" /> | ||
| </Target> | ||
|
|
||
|
|
||
| <!-- Shared logic for reference assemblies. This enables apicompat and | ||
| packaging logic for projects that have corresponding reference assemblies. --> | ||
| <PropertyGroup> | ||
| <ContractProject Condition="'$(ContractProject)' == ''">$(MSBuildProjectDirectory)\ref\$(MSBuildProjectName).csproj</ContractProject> | ||
| <HasMatchingContract Condition="Exists('$(ContractProject)')">true</HasMatchingContract> | ||
| <RunApiCompat Condition="'$(HasMatchingContract)' != 'true'">false</RunApiCompat> | ||
| <TargetsForTfmSpecificContentInPackage Condition="'$(HasMatchingContract)' == 'true'">$(TargetsForTfmSpecificContentInPackage);_AddReferenceAssemblyToPackage</TargetsForTfmSpecificContentInPackage> | ||
| </PropertyGroup> | ||
| <!-- Work around ApiCompat breaking change /~https://github.com/dotnet/arcade/issues/5361 --> | ||
| <ItemGroup Condition="'$(RunApiCompat)' == 'true'"> | ||
| <_DependencyDirectories Include="$(IntermediateOutputPath)" /> | ||
| </ItemGroup> | ||
| <!-- Add a ProjectReference to the reference assembly project for ApiCompat. --> | ||
| <!-- This also ensures that it is built when the current project gets packaged. --> | ||
| <ItemGroup Condition="'$(HasMatchingContract)' == 'true'"> | ||
| <ProjectReference Include="$(ContractProject)"> | ||
| <ReferenceOutputAssembly>false</ReferenceOutputAssembly> | ||
| <OutputItemType>ResolvedMatchingContract</OutputItemType> | ||
| </ProjectReference> | ||
| </ItemGroup> | ||
|
|
||
| <!-- The default pack logic will include the implementation assembly in lib. | ||
| This also adds the reference assembly under ref. --> | ||
| <Target Name="_AddReferenceAssemblyToPackage"> | ||
| <!-- Get the build output of the reference project, which has been built due to the ProjectReference. --> | ||
| <MSBuild Projects="$(ContractProject)" Targets="BuiltProjectOutputGroup" Properties="TargetFramework=$(TargetFramework)"> | ||
| <Output TaskParameter="TargetOutputs" ItemName="_ReferenceAssemblies" /> | ||
| </MSBuild> | ||
| <!-- Check just to be safe. --> | ||
| <Error Condition="!Exists('%(_ReferenceAssemblies.Identity)')" Text="Reference assembly %(Identity) does not exist. Ensure it has been built before packaging." /> | ||
| <!-- Add it to the package. --> | ||
| <ItemGroup> | ||
| <TfmSpecificPackageFile Include="@(_ReferenceAssemblies)" PackagePath="ref\$(TargetFramework)" /> | ||
| </ItemGroup> | ||
| </Target> | ||
|
|
||
|
|
||
| <!-- Shared logic to publish multiple projects in the same | ||
| package. Pack doesn't support including project references | ||
| (/~https://github.com/NuGet/Home/issues/3891), so we work around | ||
| this by explicitly including the publish output in the | ||
| package. --> | ||
| <PropertyGroup> | ||
| <IncludePublishOutput Condition="'$(IncludePublishOutput)' == ''">false</IncludePublishOutput> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(IncludePublishOutput)' == 'true'"> | ||
| <!-- Don't include the build output. Instead, we want to include the TargetFramework-specific publish output. --> | ||
| <IncludeBuildOutput>false</IncludeBuildOutput> | ||
| <!-- Suppress NuGet warning for package which sets IncludeBuildOutput=false, see /~https://github.com/NuGet/Home/issues/8583 --> | ||
| <NoWarn>$(NoWarn);NU5128</NoWarn> | ||
| <!-- Option to include Json files in the package. Default is to just include dlls. --> | ||
| <IncludeJsonFilesInPackage Condition="'$(IncludeJsonFilesInPackage)' == ''">false</IncludeJsonFilesInPackage> | ||
| <!-- Use a NuGet extension point to publish and set up the package files. --> | ||
| <!-- We can't use TargetsForTfmSpecificBuildOutput, because it doesn't run when IncludeBuildOutput is false. --> | ||
| <TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);_AddPublishOutputToPackage</TargetsForTfmSpecificContentInPackage> | ||
| </PropertyGroup> | ||
|
|
||
| <Target Name="_AddPublishOutputToPackage"> | ||
| <PropertyGroup> | ||
| <PublishDir>$(BaseOutputPath)$(TargetFramework)</PublishDir> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <ProjectsToPublish Include="$(MSBuildProjectFile)"> | ||
| <AdditionalProperties>TargetFramework=$(TargetFramework);PublishDir=$(PublishDir)</AdditionalProperties> | ||
| </ProjectsToPublish> | ||
| </ItemGroup> | ||
| <!-- Clean the publish directory in case there are any left-over artifacts (publish does not work incrementally). --> | ||
| <ItemGroup> | ||
| <_FilesToDelete Remove="@(_FilesToDelete)" /> | ||
| <_FilesToDelete Include="$(PublishDir)/*.dll" /> | ||
| <_FilesToDelete Include="$(PublishDir)/*.json" /> | ||
| </ItemGroup> | ||
| <Delete Files="@(_FilesToDelete)" /> | ||
| <MSBuild Projects="@(ProjectsToPublish)" Targets="Publish" /> | ||
| <ItemGroup> | ||
| <_PublishOutputInPackage Include="$(PublishDir)/*.dll" /> | ||
| <_PublishOutputInPackage Include="$(PublishDir)/*.json" Condition="'$(IncludeJsonFilesInPackage)' == 'true'" /> | ||
| </ItemGroup> | ||
| <!-- Sanity check. --> | ||
| <Error Condition="@(_PublishOutputInPackage->Count()) == 0" Text="No publish output included in package." /> | ||
| <ItemGroup> | ||
| <TfmSpecificPackageFile Include="@(_PublishOutputInPackage)" PackagePath="$(BuildOutputTargetFolder)\$(TargetFramework)" /> | ||
| </ItemGroup> | ||
| </Target> | ||
|
|
||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| Microsoft Patent Promise for Mono | ||
|
|
||
| Microsoft Corporation and its affiliates (“Microsoft”) promise not to | ||
| assert any Applicable Patents against you for making, using, selling, | ||
| offering for sale, importing, or distributing Mono. | ||
|
|
||
| If you file, maintain, or voluntarily participate in any claim in a | ||
| lawsuit alleging direct or contributory patent infringement by Mono, | ||
| or inducement of patent infringement by Mono, then your rights under | ||
| this promise will automatically terminate. | ||
|
|
||
| This promise is not an assurance that (i) any Applicable Patents are | ||
| valid or enforceable or (ii) Mono does not infringe patents or other | ||
| intellectual property rights of any third party. No rights except | ||
| those expressly stated in this promise are granted, waived or received | ||
| by Microsoft, whether by implication, exhaustion, estoppel or | ||
| otherwise. This is a personal promise directly from Microsoft to you, | ||
| and you agree as a condition of benefitting from it that no Microsoft | ||
| rights are received from suppliers, distributors, or otherwise in | ||
| connection with this promise. | ||
|
|
||
| Definitions: | ||
|
|
||
| “Mono” means those portions of the software development technology, as | ||
| originally distributed by Xamarin, Inc. or the .NET Foundation under | ||
| the name “Mono,” that implement .NET Framework Functionality, provided | ||
| that such portions at a minimum implement all of the required parts of | ||
| the mandatory provisions of Standard ECMA-335 – Common Language | ||
| Infrastructure (CLI). | ||
|
|
||
| “.NET Framework Functionality” means any functionality in Microsoft’s | ||
| .NET Framework as described in Microsoft’s API documentation on | ||
| Microsoft’s MSDN website, including the functionality in | ||
| Windowsbase.dll, but excluding all other functionality in the Windows | ||
| Presentation Foundation component of .NET Framework. | ||
|
|
||
| “Applicable Patents” are those patent claims, currently owned by | ||
| Microsoft and acquired in the future, that are necessarily infringed | ||
| by Mono. For clarity, Applicable Patents do not include any patent | ||
| claims that are infringed (x) by any underlying or enabling technology | ||
| that may be used, combined, or distributed in connection with Mono | ||
| (such as hardware, operating systems, or applications that run on | ||
| Mono), (y) only as a consequence of modification of Mono, or (z) only | ||
| by the combination of Mono with third party code. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be built even in source build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, never mind, I guess we don't need tests for source build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is meant by "source build" please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a nutshell source-build is a requirement from some Linux distributions which require source code to build. So basically when they get dotnet they actually get all the source code (one of those pieces is the runtime, but they are more pieces) and build it. The source-build repository is in charge of taking all of these pieces and glue them together, it also has an explanation of what source build is -> /~https://github.com/dotnet/source-build#source-build-goals
We want all the source code to be included, but the tests are not going to be executed once it's an app like dotnet so we exclude them using the DotNetBuildFromSource variable.