Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move linker to runtime #77149
Move linker to runtime #77149
Changes from 250 commits
5fcf5b2
0bea8ef
633b42e
8f9ee45
f5f5782
53dd873
c9a7186
92d9b50
523e771
27fcd6b
b3b639d
2248c60
711b59e
388039e
6efba4b
a45e92d
63d67fa
61cf245
ed78135
2c6959e
e5c1e22
e6d61e7
60f4498
3329287
4425957
f2af716
c6659b7
1bac0d4
22ee6b1
9cf9a33
f6a81b6
58bf9cd
a193b58
00d3eb2
50ed201
09905d7
4db2f5c
ab65c64
d5ff8a6
029de02
1948eaa
13a5a08
d000f06
79200be
e0fc7e0
f6c78d1
d3eccf4
3b017fe
0696838
b709695
03791e8
b958eb9
73c3e1f
b09c959
18e8097
b7d371e
84cb288
f51da34
24df782
c81a38e
9d7c1e1
f6a6aa5
7a68aa0
7491783
b16fe51
1df17ac
4ad23a2
db06f03
49aa059
83279b1
5f3ddb2
0624a52
fa1c5b9
3a43f07
24521fd
64adcdc
d18bd5f
c07faaf
1718dda
398a848
d4e7d66
87e64eb
bee4931
ab2bd0e
0f2faf2
0422829
a48c81a
f6950a8
ad2e12c
8e8144d
1eb466a
8dba253
3249cdb
833ad0d
d242d6e
9af3455
e14b322
ad7f96e
97981c4
aa820d2
d512298
1f15bb6
f0737f2
e0dae3e
d38e869
2e987e8
dcfe8ec
bd94741
3fdf0eb
c492274
3db5605
a7762df
659bcb5
1b18095
736d0f1
347293b
26fe218
a8bd538
83e96a6
7a5d3a7
d3e6515
10e0bda
63f6df4
59bc964
99140e9
657a094
e7624e0
70fccc4
d45c523
6231ab3
0450d9b
742f5a3
233fc93
894d09d
609cca8
ea9ab9b
ce01945
c869b10
4fdaf21
a40adc2
2a8227d
bab6a8b
00e42a0
784fede
4bf1bcf
982d2b8
1c77e69
6f6e4a6
fa43f73
2fa20c3
9a8f2c0
5340b8c
37a73e6
1434c75
eedc180
d9c3249
5e073ae
3707a37
fe18f19
99e5df3
c1400cf
c6f3a67
0f361d9
68a6b6a
9f6a97c
fcd58bd
c3ae17c
0e33465
01652f4
4361681
96a5d72
e522d58
e33aab6
f35559b
b8e2e1c
d4481ef
d4f0b87
2e5b893
7d404e9
44c4742
a571ef1
011aab4
a027f21
eccba9a
fee2bb1
8120f77
f74729a
b117fa0
b60d366
9e7bdbf
ffdcf15
21c440a
4e75a56
ee43bd2
60e99cc
8e5af0a
015cfd4
a67ebf3
8c295a7
8e40f0b
1776452
8c6f47f
f3d31d4
b2437ee
cabc760
6b5e37e
6ac7820
69cc1e2
bf57dbb
61ac4ff
e966196
faa322a
11af0c1
244e25c
6eecc0c
6fed335
bd2bb82
668d000
d707852
3138b2c
c678f44
304e1ca
c27a0a3
eb6d176
229f829
cdfa89e
87f3ac1
fa2e881
2cb62ff
b7d664c
d433f19
6698128
12f4ea1
01a13e9
2ddff0a
d615e00
2d44ea4
aaba9e1
89d94ed
a10d6c4
3db6dda
0ec286d
8c6a936
d016c82
0412b85
312ac9a
eb4482e
7ed5f12
b654deb
10e4841
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be built even in source build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, never mind, I guess we don't need tests for source build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is meant by "source build" please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a nutshell source-build is a requirement from some Linux distributions which require source code to build. So basically when they get dotnet they actually get all the source code (one of those pieces is the runtime, but they are more pieces) and build it. The source-build repository is in charge of taking all of these pieces and glue them together, it also has an explanation of what source build is -> /~https://github.com/dotnet/source-build#source-build-goals
We want all the source code to be included, but the tests are not going to be executed once it's an app like dotnet so we exclude them using the DotNetBuildFromSource variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this and use repo-wide global configurations (
CodeAnalysis.{src,test}.globalconfig
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already takes into account the CodeAnalysis.{src,test}.globalconfig. This is an override of what's in that file. For example, IDE0005 is not enabled globally because a lot of the files in the runtime have
#ifdef
that could incorrectly flag unnecessary usings/imports, but in the case of linker we use that rule. The original editorconfig from linker is actually more comprehensive than this file, but since is inheriting most from the globalconfig these were the only remaining items