-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SingleFile diagnostic support - Add export table and DotNetRuntimeInfo to dumps #52731
Conversation
Tagging subscribers to this area: @tommcdon Issue Details
DACize the extraction of exports and account for mapped vs non-mapped versions. @trylek, could you please check this first commit.
|
2e58772
to
443504f
Compare
443504f
to
35a2f6b
Compare
35a2f6b
to
df6d02f
Compare
df6d02f
to
8fde24e
Compare
@trylek, had to fix a bug in the |
No pipelines are associated with this pull request. |
/azp list |
/azp run runtime-coreclr crossgen2-composite |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fix. Can you please double-check that the corresponding code in R2RDump is correct? I think it is but you have the structure in fresh memory now ;-).
runtime/src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/PEReaderExtensions.cs
Line 19 in 6430375
private PEExportTable(PEReader peReader) |
@trylek I've verified both the PEReader extensions and |
@hoyoys - Thank you! For the composite runs, all failures I'm seeing correspond to known issues. I have a long-haul PR #51416 to fix part of them but it's taking a bit due to a complex discussion on the proper fix and the nullrefs on OSX arm64 are a known codegen issue unrelated to Crossgen2 I believe. |
DACize the extraction of exports and account for mapped vs non-mapped versions. @trylek, could you please check this first commit.