Move WeakEventManager to Core.csproj

[TheCodeTraveler]

Description of Change

This PR moves WeakEventManager to the Core.csproj project and updates its namespace:

• Moving WeakEventManager.cs
  • src/Controls/src/Core/WeakEventManager.cs -> src/Core/src/WeakEventManager.cs
• Updating WeakEventManager Namespace
  • namespace Microsoft.Maui.Controls -> namespace Microsoft.Maui

Additionally, this PR moves the associated Unit Tests to Core.UnitTests.csproj and updates its namespace:

• Moving WeakEventManagerTests.cs
  • src/Controls/tests/Core.UnitTests/WeakEventManagerTests.cs → src/Core/tests/UnitTests/WeakEventManagerTests.cs
• Updating WeakEventManagerTests Namespace
  • Microsoft.Maui.Controls.Core.UnitTests -> Microsoft.Maui.UnitTests

Additional Information

On the .NET MAUI Community Toolkit team, we strive to keep the .NET MAUI Community Toolkit architecture aligned with the .NET MAUI architecture. To accomplish this, we have a CommunityToolkit.Maui.Core project that maps to the .NET MAUI code in Core.csproj (aka /src/Core/).

Mimicking .NET MAUI's architecture ensures a frictionless process to promote features from the .NET MAUI Community Toolkit into .NET MAUI once the features have matured and been approved.

We'd really love to use WeakEventManager with our Core project, but right now we can't because it's in the *.Controls namespace.

Moving WeakEventManager to Core.csproj also allows other Frameworks built using .NET MAUI (e.g. Comet, BlazorWebView) to also leverage WeakEventManager.

.NET MAUI Community Toolkit Contributions Guide

/~https://github.com/CommunityToolkit/Maui/blob/main/CONTRIBUTING.md#where-to-make-your-changes

[TheCodeTraveler]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 5139 in repo dotnet/maui

[Clancey]

I am fine with this being in Core. It might come in handy with our handlers and native events. As long as this doesn't encourage/have us adding events on our interfaces.

[rmarinho]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[TheCodeTraveler]

I've updated this PR to fix the CI errors caused by not previously updating the XML docs references.

I think I did it correctly, but would be good to double-check my work with WeakEventManager.xml 👍

[mattleibow]

Approving this as we probs need it in core and should use it for platform subscriptions.

But, is approval only applies if this feature does not exist in the BCL. It has been years since forms was created, have we added something like this to the BCL yet? Either an API or a language feature?

[TheCodeTraveler]

Thanks @mattleibow!

WeakEventManager is not yet in the .NET BCL, but there is an open Issue requesting it to be added based on our implementation: dotnet/runtime#61517 (comment)

[TheCodeTraveler]

/azp run

Edit: Dang - I was really hoping it would work after trying it again a 2nd time 😅

[azure-pipelines]

Commenter does not have sufficient privileges for PR 5139 in repo dotnet/maui

[azure-pipelines]

Command 'run

Edit:' is not supported by Azure Pipelines.



Supported commands

• help:
• Get descriptions, examples and documentation about supported commands
• Example: help "command_name"
• list:
• List all pipelines for this repository using a comment.
• Example: "list"
• run:
• Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
• Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
• where:
• Report back the Azure DevOps orgs that are related to this repository and org
• Example: "where"

See additional documentation.

[Redth]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[mattleibow]

/azp run

[azure-pipelines]

Pull request contains merge conflicts.

[TheCodeTraveler]

Can I get another /azp run to see if the docs build script is fixed?

[mattleibow]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).