Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix for SearchHandler Fails to Display Results. #26572

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman commented Dec 12, 2024

Root Cause of the issue

  • When the SearchHandler's ItemTemplate is null, it applies an incorrect ItemsSource and ItemTemplate to the AutoSuggestBox.

Description of Change

  • I resolved the issue by assigning the correct ItemsSource and ItemTemplate from the SearchHandler to the AutoSuggestBox when the SearchHandler's ItemTemplate is null.

Test Case

Reference

/~https://github.com/dotnet/maui/blob/main/src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs#L279

/~https://github.com/dotnet/maui/blob/main/src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs#L267

Issues Fixed

Fixes #26477

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
SearchHandlerIssueV.mp4
SearchHandlerFix.mp4

Copy link
Contributor

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 12, 2024
@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 12, 2024
@jfversluis jfversluis added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Dec 12, 2024
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review December 13, 2024 07:51
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner December 13, 2024 07:51
@jfversluis
Copy link
Member

jfversluis commented Dec 16, 2024

/azp run

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit 06cccd4 into dotnet:main Jan 10, 2025
104 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchHandler Fails to Display Results on Windows
6 participants