Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analyzer for TestCase and missing Category #23465

Closed
wants to merge 1 commit into from
Closed

Add analyzer for TestCase and missing Category #23465

wants to merge 1 commit into from

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Jul 6, 2024 •
edited
Loading

Description of Change

As per #23464 [TestCase] wasn't picked up by the analyzer, not is should detect those too.

@jfversluis jfversluis added the area-testing Unit tests, device tests label Jul 6, 2024
@jfversluis jfversluis requested review from Redth and PureWeen July 6, 2024 10:23
@jfversluis jfversluis self-assigned this Jul 6, 2024
@jfversluis jfversluis requested a review from a team as a code owner July 6, 2024 10:23
@jfversluis
Copy link
Member Author

/rebase

@github-actions github-actions bot force-pushed the add-testcase-analyzer branch from 1d31695 to 9c63391 Compare July 6, 2024 11:16
@jfversluis jfversluis marked this pull request as draft July 6, 2024 12:19
@jfversluis
Copy link
Member Author

[TestCase] is a little different as it can have a category as part of the constructor. We need to pick that up. And also double-check if that actually works with the category running right now?

@PureWeen
Copy link
Member

PureWeen commented Jul 9, 2024

/rebase

@github-actions github-actions bot force-pushed the add-testcase-analyzer branch from 9c63391 to 2319104 Compare July 9, 2024 16:24
@PureWeen PureWeen modified the milestones: .NET 9 SR2, .NET 9 Servicing Oct 31, 2024
@jfversluis
Copy link
Member Author

Lets revisit this later. Or not.

@jfversluis jfversluis closed this Nov 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Awaiting requested review from Redth

@PureWeen PureWeen Awaiting requested review from PureWeen

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@jfversluis jfversluis

Labels
area-testing Unit tests, device tests
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 9 Servicing
Development

Successfully merging this pull request may close these issues.
2 participants
@jfversluis @PureWeen