Skip to content

Commit

Permalink
[tools] Don't link with NewsstandKit if we're using Xcode 15+. (#18626)
Browse files Browse the repository at this point in the history
Apple completely removed the NewsstandKit framework in Xode 15.

This effectively adds basic support for using Xcode 15 with .NET 7.

While this technically won't be a supported scenario, we have tests that
ensures .NET 7 apps can be built with .NET 8, and .NET 8 will ship with Xcode
15 support. This means that in order to make these tests work, we'll otherwise
have to have Xcode 14.3 installed both locally and on bots (in addition to
Xcode 15 of course), which is a rather big nightmare.

It's much easier to must try to make Xcode 15 work with .NET 7.
  • Loading branch information
rolfbjarne authored Aug 3, 2023
1 parent 82a5174 commit 5ea3eb3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/UIKit/UIMenu.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public partial class UIMenu {
[SupportedOSPlatform ("maccatalyst15.0")]
#else
[iOS (15, 0)]
[TV (15,0)]
[TV (15, 0)]
#endif
public virtual UIMenuElement [] SelectedElements {
get {
Expand Down
6 changes: 6 additions & 0 deletions tools/common/Frameworks.cs
Original file line number Diff line number Diff line change
Expand Up @@ -799,6 +799,12 @@ static bool FilterFrameworks (Application app, Framework framework)
return false;
}
break;
case "NewsstandKit":
if (Driver.XcodeVersion.Major >= 15) {
Driver.Log (3, "Not linking with the framework {0} because it's been removed from Xcode 15+.", framework.Name);
return false;
}
break;
}
break;
case ApplePlatform.TVOS:
Expand Down

5 comments on commit 5ea3eb3

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

Please sign in to comment.