Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assembly version diff test for missing file #20212

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix assembly version diff test for missing file #20212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/SdkContentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,11 @@ private static void RemoveExcludedAssemblyVersionPaths(Dictionary<string, Versio
{
string assemblyPath = sbSdkFileArray[i];
Version? sbVersion = sbSdkAssemblyVersions[assemblyPath];
Version? msftVersion = msftSdkAssemblyVersions[assemblyPath];
if (!msftSdkAssemblyVersions.TryGetValue(assemblyPath, out Version? msftVersion))
{
sbSdkAssemblyVersions.Remove(assemblyPath);
continue;
}

if (sbVersion is not null &&
msftVersion is not null &&
Expand Down Expand Up @@ -163,7 +167,7 @@ private string FindMatchingFilePath(string rootDir, Matcher matcher, string repr
}
}

Assert.Fail($"Unable to find matching file for '{representativeFile}' in '{rootDir}'.");
OutputHelper.WriteLine($"Unable to find matching file for '{representativeFile}' in '{rootDir}'.");
return string.Empty;
}

Expand Down