Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure Service Bus integration doc #2365

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Update Azure Service Bus integration doc #2365

merged 8 commits into from
Feb 11, 2025

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jan 8, 2025 •
edited by github-actions bot
Loading

Summary

Caution

Currently blocked by the release of .NET Aspire 9.1. Various APIs and xref links will not render correctly and are missing.

Rewrite Azure Service Bus integration article.

Fixes #2308

Internal previews

📄 File 🔗 Preview link
docs/messaging/azure-service-bus-integration.md .NET Aspire Azure Service Bus integration

@dotnetrepoman dotnetrepoman bot added the messaging Content related to messaging. label Jan 8, 2025
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-health KR: Concerns article defects/freshness or build warnings. label Jan 8, 2025
@IEvangelist IEvangelist requested a review from CamSoper January 8, 2025 20:08
@IEvangelist IEvangelist marked this pull request as draft January 8, 2025 20:08
@IEvangelist IEvangelist changed the title Fixes #2308 Update Azure Service Bus integration doc Jan 8, 2025
@CamSoper CamSoper requested a review from Copilot January 8, 2025 20:29
Copilot
Copilot AI reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

CamSoper
CamSoper approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there any way to do passwordless in Aspire? Should we include that information?

@IEvangelist IEvangelist mentioned this pull request Feb 5, 2025
Open
3 tasks
@IEvangelist IEvangelist changed the base branch from main to dotnet-aspire-9.1 February 6, 2025 21:06
@IEvangelist IEvangelist marked this pull request as ready for review February 6, 2025 21:09
@IEvangelist IEvangelist merged commit 119fd28 into dotnet:dotnet-aspire-9.1 Feb 11, 2025
5 of 6 checks passed
IEvangelist added a commit to IEvangelist/docs-aspire that referenced this pull request Feb 11, 2025
@IEvangelist
Update Azure Service Bus integration doc (dotnet#2365)
a95d4f1 
* Fixes dotnet#2308

* Fix tabs

* Fix a few more bits

* Remove subscription section and correct topics

* Fix port info

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review
IEvangelist added a commit to IEvangelist/docs-aspire that referenced this pull request Feb 18, 2025
@IEvangelist
Update Azure Service Bus integration doc (dotnet#2365)
66f3538 
* Fixes dotnet#2308

* Fix tabs

* Fix a few more bits

* Remove subscription section and correct topics

* Fix port info

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review
IEvangelist added a commit to IEvangelist/docs-aspire that referenced this pull request Feb 18, 2025
@IEvangelist
Update Azure Service Bus integration doc (dotnet#2365)
8525592 
* Fixes dotnet#2308

* Fix tabs

* Fix a few more bits

* Remove subscription section and correct topics

* Fix port info

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review
IEvangelist added a commit to IEvangelist/docs-aspire that referenced this pull request Feb 19, 2025
@IEvangelist
Update Azure Service Bus integration doc (dotnet#2365)
2eca627 
* Fixes dotnet#2308

* Fix tabs

* Fix a few more bits

* Remove subscription section and correct topics

* Fix port info

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review
IEvangelist added a commit that referenced this pull request Feb 21, 2025
@mitchdenny @captainsafia
@IEvangelist @ReubenBond @JamesNK
.NET Aspire and GitHub Codespaces/Devcontainers (#2638)
3334853 
* Update docs/serverless/functions.md

* Update Azure Service Bus integration doc (#2365)

* Fixes #2308

* Fix tabs

* Fix a few more bits

* Remove subscription section and correct topics

* Fix port info

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Resource notifications (#2568)

* Document DistributedApplication.ResourceNotifications and WaitForResourceHealthyAsync

* Minor edit pass, and bump ms.date

---------

Co-authored-by: Reuben Bond <reuben.bond@gmail.com>

* Fixes breaking changes doc issues (#2619)

* Fixes breaking changes doc issues

* Fix links

* Correct front-matter

* Add index

* Shell for what's new content (#2620)

* Fixes #1659 (#2621)

* Rewritten Azure Event Hubs integration content (#2562)

* Wip

* Rewrite of Azure Event Hubs, looks like 9.1 target

* Minor edit

* Fix broken links

* Correct link again

* Upgrade bits to 9.1 (#2627)

* Upgrade NuGet packages, and corrected preview headings

* Revert one incorrect change

* Bump version

* Correct Dapr version

* [9.1] Force waiting resource to start (#2629)

* [9.1] Add WithExplicitStart (#2630)

* [9.1] Add WithExplicitStart

* Update docs/fundamentals/app-host-overview.md

* Add DOTNET_DASHBOARD_CORS_ALLOWED_ORIGINS to app host configuration (#2631)

* Fix invalid file link warning (#2635)

* Codespaces docs.

* Remove pivot.

* Pivot removal.

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/devcontainers.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/devcontainers.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/devcontainers.md

Co-authored-by: David Pine <david.pine@microsoft.com>

---------

Co-authored-by: Safia Abdalla <safia@safia.rocks>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Reuben Bond <reuben.bond@gmail.com>
Co-authored-by: James Newton-King <james@newtonking.com>
IEvangelist added a commit that referenced this pull request Feb 25, 2025
@IEvangelist @captainsafia
@ReubenBond @JamesNK @maddymontaquila @Copilot @eerhardt @davidfowl @mitchdenny @sebastienros
Content for .NET Aspire 9.1 (#2566)
cab7881 
* Update docs/serverless/functions.md

* Update Azure Service Bus integration doc (#2365)

* Fixes #2308

* Fix tabs

* Fix a few more bits

* Remove subscription section and correct topics

* Fix port info

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Resource notifications (#2568)

* Document DistributedApplication.ResourceNotifications and WaitForResourceHealthyAsync

* Minor edit pass, and bump ms.date

---------

Co-authored-by: Reuben Bond <reuben.bond@gmail.com>

* Fixes breaking changes doc issues (#2619)

* Fixes breaking changes doc issues

* Fix links

* Correct front-matter

* Add index

* Shell for what's new content (#2620)

* Fixes #1659 (#2621)

* Rewritten Azure Event Hubs integration content (#2562)

* Wip

* Rewrite of Azure Event Hubs, looks like 9.1 target

* Minor edit

* Fix broken links

* Correct link again

* Upgrade bits to 9.1 (#2627)

* Upgrade NuGet packages, and corrected preview headings

* Revert one incorrect change

* Bump version

* Correct Dapr version

* [9.1] Force waiting resource to start (#2629)

* [9.1] Add WithExplicitStart (#2630)

* [9.1] Add WithExplicitStart

* Update docs/fundamentals/app-host-overview.md

* Add DOTNET_DASHBOARD_CORS_ALLOWED_ORIGINS to app host configuration (#2631)

* Fix invalid file link warning (#2635)

* [9.1] Add resource relationship docs (#2637)

* Add resource relationship docs

* Fix linter

* Update

* Update

* Update

* Update

* Apply suggestions from code review

---------

Co-authored-by: David Pine <david.pine@microsoft.com>

* Wat's new (#2622)

* scaffolding pt 1

* adding the scaffold from pine

* first full pass

* wow copilot is helpful

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* erics edits (ty!)

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

* Good finds from James

Co-authored-by: James Newton-King <james@newtonking.com>

* moving console logs downloads to its own section in dashboard

* Apply suggestions from code review

Co-authored-by: James Newton-King <james@newtonking.com>

* Update docs/whats-new/dotnet-aspire-9.1.md

* Apply suggestions from code review

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

* Edit pass on the what's new content (#2636)

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: James Newton-King <james@newtonking.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>

* Version-suffixed NuGet client integrations (#2643)

* Add details about client integrations with version-suffix. Fixes #2360

* Feedback

* [9.1] Add remove logs and telemetry to what's new (#2645)

* Adds the NATS 9.1 API and fixes obsolete API. (#2650)

* Adds the NATS 9.1 API and fixes obsolete API. Closes #1817

* Fix link

* A bit of clean up

* Update breaking changes docs (#2651)

* Update breaking changes docs

* Update breaking changes index

* Fix copy paste errors

* Update SB to include subscription

* update TOC

* Existing Azure resources (#2653)

* Rework PR

* Apply suggestions from code review

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

* Correct phrasing for local containers

* Apply suggestions from code review

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

* Re-generate Bicep and manifest. Also, more feedback

* Fix MD lint

---------

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

* Add docs for CosmosDB preview emulator (#2654)

Fix #2376

* Apply suggestions from code review

Co-authored-by: James Newton-King <james@newtonking.com>

* Fixed misc feedback

* Fix heading link

* .NET Aspire and GitHub Codespaces/Devcontainers (#2638)

* Update docs/serverless/functions.md

* Update Azure Service Bus integration doc (#2365)

* Fixes #2308

* Fix tabs

* Fix a few more bits

* Remove subscription section and correct topics

* Fix port info

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Resource notifications (#2568)

* Document DistributedApplication.ResourceNotifications and WaitForResourceHealthyAsync

* Minor edit pass, and bump ms.date

---------

Co-authored-by: Reuben Bond <reuben.bond@gmail.com>

* Fixes breaking changes doc issues (#2619)

* Fixes breaking changes doc issues

* Fix links

* Correct front-matter

* Add index

* Shell for what's new content (#2620)

* Fixes #1659 (#2621)

* Rewritten Azure Event Hubs integration content (#2562)

* Wip

* Rewrite of Azure Event Hubs, looks like 9.1 target

* Minor edit

* Fix broken links

* Correct link again

* Upgrade bits to 9.1 (#2627)

* Upgrade NuGet packages, and corrected preview headings

* Revert one incorrect change

* Bump version

* Correct Dapr version

* [9.1] Force waiting resource to start (#2629)

* [9.1] Add WithExplicitStart (#2630)

* [9.1] Add WithExplicitStart

* Update docs/fundamentals/app-host-overview.md

* Add DOTNET_DASHBOARD_CORS_ALLOWED_ORIGINS to app host configuration (#2631)

* Fix invalid file link warning (#2635)

* Codespaces docs.

* Remove pivot.

* Pivot removal.

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/codespaces.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/devcontainers.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/devcontainers.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/fundamentals/devcontainers.md

Co-authored-by: David Pine <david.pine@microsoft.com>

---------

Co-authored-by: Safia Abdalla <safia@safia.rocks>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Reuben Bond <reuben.bond@gmail.com>
Co-authored-by: James Newton-King <james@newtonking.com>

* Codespaces and dev containers (#2655)

* Initial clean up

* Edit pass

* Use hardcoded JSON for now

* Fix image, move it

* Add links from what's new

* Update CosmosDB, EventHubs, and ServiceBus for latest APIs. (#2656)

* Update devcontainer.

* Bicep too.

* Add CosmosDB container creation (#2661)

* Enhance Integrations What's New in 9.1 (#2657)

* Enhance Integrations What's New in 9.1

* md lint

* add disable experimental

* Add ComsosDB func trigger

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: David Pine <david.pine@microsoft.com>

* Local-devcontainers (#2662)

* Local Devcontainers.

* Remove Azure features from devcontainer.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: David Pine <david.pine@microsoft.com>

* Edit pass and clean up

* Clean up images

* Add link from setup to codespaces and dev containers

* Another edit pass

* Remove misleading links

* Remove details/summary HTML - usability concerns

* Fix triple : code bits

* Move Upgrade to 9.1 to the top (#2668)

* Add testing overview doc (#2667)

* Add testing overview doc to explain how Aspire testing works, update tutorial, add detail on passing args to the app host

* Update dates

* Apply suggestions from code review

---------

Co-authored-by: David Pine <david.pine@microsoft.com>

* Edit pass on testing docs

* Clean builds, except xref

* Add code snippet for using new Azure emulators

* fixup

* Tweak the wording of CosmosDB databases and containers (#2670)

* Another edit pass

* Fix typo

* Adjust h2s

* Fix bookmark

* Clean up, additions, and removal of mistakenly dup'd content

* More rewording and messaging updates

* More rewording and messaging updates

* Additional details

* Headings

* Add more links, clarify text, and use ref branch

* Add breaking changes link

* A few xref bits for fun

* Point to .NET Aspire 9.1 API docs

* Remove a few things

---------

Co-authored-by: Safia Abdalla <safia@safia.rocks>
Co-authored-by: Reuben Bond <reuben.bond@gmail.com>
Co-authored-by: James Newton-King <james@newtonking.com>
Co-authored-by: Maddy Montaquila (Leger) <maddyleger1@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: Mitch Denny <midenn@microsoft.com>
Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
Co-authored-by: Reuben Bond <203839+ReubenBond@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@CamSoper CamSoper CamSoper approved these changes

Assignees
No one assigned
Labels
messaging Content related to messaging. okr-quality Content-health KR: Concerns article defects/freshness or build warnings.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite of the Azure Service Bus integration article
2 participants
@IEvangelist @CamSoper