Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add additional globalization settings #9348

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Oct 27, 2023

What's included in this PR

  • Add solution-wide <PredefinedCulturesOnly>false</PredefinedCulturesOnly> settings.
    • This settings allow to create new CultureInfo("custom-lang"); when running under InvariantGlobalization mode.
    • This settings is required to use resx-based localization on custom plugins DLL
  • Add <SatelliteResourceLanguages>en</SatelliteResourceLanguages> settings for test projects. to reduce disk space consumption.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yufeih
Copy link
Contributor

yufeih commented Oct 27, 2023

Will this fix #9203?

@filzrev
Copy link
Contributor Author

filzrev commented Oct 27, 2023

Will this fix #9203?

It seems build error is resolved by this PR.

But it should be noted that there are some behavior differences.
Because SourceGenerator(Analyzer) is running with created custom culture.

  • Created culture is based on InvariantCulture.
  • Created culture don't have Parent culture
    (When creating en-US culture. Parent property is null by default. And can't customize GeneratedRegexAttribute)

@yufeih yufeih merged commit 7578819 into dotnet:main Oct 28, 2023
7 checks passed
@yufeih
Copy link
Contributor

yufeih commented Oct 28, 2023

Great!

p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
chore: add additional globalization settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants