Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PDF builder using Chromium #9344

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat: PDF builder using Chromium #9344

merged 2 commits into from
Oct 26, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Oct 26, 2023 •
edited
Loading

Adds PDF builder that prints PDF pages using Playwright and then stitch the pages together using PdfPig.

#9343

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Docfx.App/PdfBuilder.cs 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@yufeih yufeih marked this pull request as ready for review October 26, 2023 08:09
@yufeih yufeih merged commit c81fef3 into main Oct 26, 2023
7 checks passed
@yufeih yufeih deleted the newpdf branch October 26, 2023 09:26
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
@yufeih @p-kostov
feat: PDF builder using Chromium (dotnet#9344)
c51f512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yufeih