Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash fixes for CopyInherited #7709

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Crash fixes for CopyInherited #7709

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26ea6f6
Crash fixes for CopyInherited
Sorpirit Nov 15, 2021
baab569
Merge branch 'dev' into dev
yufeih Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.DocAsCode.Metadata.ManagedReference/Resolvers/CopyInheritedDocumentation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ private static void InheritDoc(MetadataItem dest, ResolverContext context)
Debug.Assert(dest.Parent.Type == MemberType.Class);

//try to find the base class
if (dest.Parent.Inheritance?.Count == 0)
if (dest.Parent.Inheritance == null || dest.Parent.Inheritance.Count == 0)
{
return;
}
Expand Down Expand Up @@ -128,7 +128,7 @@ private static void Copy(MetadataItem dest, string srcName, ResolverContext cont
MetadataItem src = null;

// An explicit <inheritdoc/> (i.e. cref) overrides the default behavior
if (!string.IsNullOrEmpty(dest.InheritDoc) && context.Members.TryGetValue(dest.InheritDoc, out src))
if (!string.IsNullOrEmpty(dest.InheritDoc) && context.Members.TryGetValue(dest.InheritDoc, out src) && dest != src)
{
srcName = dest.InheritDoc;
}
Expand Down