Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support processing --useHttps flag on Functions applications #7789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

captainsafia
Copy link
Member

Description

The Functions host supports passing a --useHttps flag to support binding to https://localhost:* instead of http://localhost:*. This change supports picking up this flag and mapping to a target endpoint with the correct scheme.

There's likely more work to be done here (validate what happens with custom certs, etc.) but this wires up the Aspire-specific things at least.

Conributes to #7150

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot bot review requested due to automatic review settings February 26, 2025 17:01

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@davidfowl
Copy link
Member

We should be supporting both http and https. Does that work with the host?

@captainsafia
Copy link
Member Author

We should be supporting both http and https. Does that work with the host?

AFAIK, the Functions host doesn't support being able to listen on HTTP and HTTPS ports at the same time.

@davidfowl
Copy link
Member

I don't know if that is a blocker or not, but the tests are failing. So the idea is that when somebody opts into this they only get https. We ignore this during deployment right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants