-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A fix to the use of <remark> tags rather than <remarks> in the documentation comments #1776
A fix to the use of <remark> tags rather than <remarks> in the documentation comments #1776
Conversation
I have read the Contribution License Agreement. I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for any of my past employers. (Note that I am not employed by anybody at the moment, looking for a new job... :) |
Thanks @AlissaSabre. Can you commit the changes to the generated code? We persist those so we can see what the changes are - yeah, it makes for a larger change anytime you make a change there, but it's proven helpful to see the impact. |
@twsouthwick Thank you for checking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What you're getting at here is probably that VS (or any long lived roslyn process) doesn't reload analyzers/generators/code fixers. I've never had to restart Windows - restarting VS is usually sufficient. Also, removing the |
Test Results 70 files 70 suites 1h 0m 36s ⏱️ Results for commit 7e08714. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR fixes #1775
The changes to the generated source files (i.e., those ingenerated/
) are not included in this PR, because they will be re-generated by the updated code generator when building. (You will need to commit those changes to the repository by yourself...)The changes to the generated source files are now included in the PR in commit 7e08714 for easier review.
Note that, for the purpose of testing the behavior of the patched generator, you will need to do the following:
dotnet clean
, then remove all files in (subdirectories of)generated/
manually before runningdotnet build
.