Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doom-meltbus-theme.el warnings using unspecified instead nil #851

Closed
wants to merge 1 commit into from

Conversation

ryukinix
Copy link

@ryukinix ryukinix commented Dec 26, 2024

Fix doom-meltbus theme around problem reported at #793

Ref: #793


  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to Doom's git conventions.
  • Any relevant issues or PRs have been linked to.

Fix doom-meltbus theme around problem reported at doomemacs#793 793
@hlissner hlissner added is:bug Something isn't working as intended theme:meltbus labels Jan 10, 2025
@hlissner hlissner added this to the v2.4.0 milestone Jan 10, 2025
@hlissner
Copy link
Member

As of b668cbb these sort of fixes (and the underlying warnings) should no longer be necessary (as our themes will treat nil as unspecified from now on), so I must turn down this PR, but thanks for bringing it to my attention in any case!

@hlissner hlissner closed this Jan 10, 2025
@hlissner hlissner added the was:moved Is, was, or will be addressed elsewhere label Jan 10, 2025
@ryukinix
Copy link
Author

ryukinix commented Jan 11, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something isn't working as intended theme:meltbus was:moved Is, was, or will be addressed elsewhere
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants