Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cte naming conflict #2812

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Fix cte naming conflict #2812

merged 3 commits into from
Jan 13, 2025

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Jan 12, 2025 •
edited
Loading

fixes: dolthub/dolt#8724

Distinct CTE references need unique column and table ids.

@max-hoffman max-hoffman requested a review from jycor January 13, 2025 18:33
jycor
jycor approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-hoffman max-hoffman merged commit b01a7c6 into main Jan 13, 2025
8 checks passed
@max-hoffman max-hoffman deleted the max/cte-naming-conflict branch January 13, 2025 21:59
@samjewell
Copy link
Contributor

This is awesome 🎉
Thanks for making this change @max-hoffman @jycor

@BrewTestBot BrewTestBot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect SUM calculation in CTE with correlated subquery
3 participants
@max-hoffman @samjewell @jycor