Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] support for dialect specific engine test skips #2783

Merged
merged 9 commits into from
Dec 6, 2024
Merged

[no-release-notes] support for dialect specific engine test skips #2783

merged 9 commits into from
Dec 6, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Dec 5, 2024

Also includes some minor changes to test harness initialization

@zachmu zachmu requested a review from max-hoffman December 5, 2024 22:27
max-hoffman
max-hoffman approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we've been editing GMS behavior specifically for postgres recently, wonder if adding some of those dialect tests in GMS could help prevent regressions

@zachmu zachmu merged commit d3cdbb6 into main Dec 6, 2024
7 of 8 checks passed
@max-hoffman max-hoffman deleted the zachmu/enginetest10 branch December 7, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @max-hoffman