Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix NOT expression in conjunction with WHERE EXISTS(<subquery>) #2331

Merged
merged 1 commit into from
Feb 18, 2024
Merged

fix NOT expression in conjunction with WHERE EXISTS(<subquery>) #2331

merged 1 commit into from
Feb 18, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Feb 16, 2024 •
edited
Loading

The analyzer rule unnest_exists_subqueries was accidentally dropping NOT expressions when hoisting subqueries from WHERE EXISTS... clauses.

This should fix 8 sqllogictests.
Correctness: dolthub/dolt#7510

max-hoffman
max-hoffman approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jycor jycor merged commit 404b39e into main Feb 18, 2024
8 checks passed
@jycor jycor deleted the james/exists branch February 18, 2024 09:47
This was referenced Feb 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @max-hoffman