feat(sozo-bindgen): add i8,i16,i32,i64 support

[MartianGreed]

Description

Related issue

Tests

• Yes
• No, because they aren't needed
• No, because I need help

Added to documentation?

• README.md
• Dojo Book
• No documentation needed

Checklist

• I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
• I've linted my code (scripts/clippy.sh, scripts/docs.sh)
• I've commented my code
• I've requested a review after addressing the comments

Summary by CodeRabbit

• New Features
  • Added support for signed integer types (i8, i16, i32, i64) in type mapping and code generation
  • Expanded type conversion capabilities for Cairo integer types

[coderabbitai]

Walkthrough

Ohayo, sensei! This pull request introduces four new constants for signed integer types (CAIRO_I8, CAIRO_I16, CAIRO_I32, and CAIRO_I64) in the TypeScript generator's constants and module files. These constants expand the type mapping capabilities for Cairo's signed integer types, ensuring proper handling and conversion in the code generation process. The changes are minimal and focused on enhancing type support.

Changes

File	Change Summary
crates/dojo/.../constants.rs	Added 4 new constants for signed integer types: CAIRO_I8, CAIRO_I16, CAIRO_I32, CAIRO_I64
crates/dojo/.../mod.rs	Updated type mappings and default value generation to include the new signed integer constants

Possibly related PRs

• feat: change enum to CairoCustomEnum #2907: Addition of CAIRO_UNIT_TYPE constant, indicating ongoing enhancement of Cairo data type constants

Suggested reviewers

• glihm

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

crates/dojo/bindgen/src/plugins/typescript/generator/mod.rs (1)

228-231: Consider documenting default value choice.

While the implementation is correct, it might be helpful to add a comment explaining why "0" was chosen as the default value for signed integers.

+    // Default value of 0 is chosen as it's a safe initial value for both positive and negative ranges
     CAIRO_I8 => JsPrimitiveDefaultValue("0".to_string()),
     CAIRO_I16 => JsPrimitiveDefaultValue("0".to_string()),
     CAIRO_I32 => JsPrimitiveDefaultValue("0".to_string()),
     CAIRO_I64 => JsPrimitiveDefaultValue("0".to_string()),

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2dd3ead and 86f8948.

📒 Files selected for processing (2)

• crates/dojo/bindgen/src/plugins/typescript/generator/constants.rs (1 hunks)
• crates/dojo/bindgen/src/plugins/typescript/generator/mod.rs (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: fmt

🔇 Additional comments (4)

crates/dojo/bindgen/src/plugins/typescript/generator/constants.rs (1)

11-14: Ohayo! LGTM - Clean and consistent constant declarations.

The new signed integer type constants follow the established naming pattern and are logically placed alongside other integer types.

crates/dojo/bindgen/src/plugins/typescript/generator/mod.rs (3)

76-79: Clean implementation of signed integer type mappings, sensei!

The mapping to JS_BIGNUMBERISH is appropriate for signed integers, maintaining consistency with unsigned integer handling.

---

158-161: Consistent input type mapping implementation!

The input type mappings mirror the JsPrimitiveType implementation, maintaining a coherent type system.

---

76-79: Verify test coverage for new integer types.

Please ensure that test cases exist for the new signed integer types in the test module, particularly for edge cases like minimum and maximum values.

Also applies to: 158-161, 228-231