feat(sozo): add support for v3 transactions #2498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not necessarily blocked, but katana is yet to fully support v3 transactions due to no STRK token declared ref #2405 |
kariy
added a commit
that referenced
this pull request
Oct 14, 2024
ref #2498 #2405 - update the default predeployed account class implementation to OZ `0.17.0` account [preset](/~https://github.com/OpenZeppelin/cairo-contracts/blob/v0.17.0/packages/presets/src/account.cairo) - rename class constants is it required to change the account implementation because the version we're using doesn't support transaction version > 1 as seen below: /~https://github.com/OpenZeppelin/cairo-contracts/blob/6ab91b5cf57d6a7d02f2d5c5abfc7b5712bc8e47/src/account/account.cairo#L75C1-L77C14 technically v3 support is later added in OZ `0.8.1`. so going all the way to `0.17.0` may seem exaggerated, but `0.8.1` is ~8 months old now so better to just use the latest compatible version. tbh i dont exactly know how different `0.17.0` is compared to `0.8.1`.
|
@lambda-0x since @kariy merged the STRK token, when core will be merged let's rebase this one to unlock v3. As @kariy mentioned if by default we could have sozo choosing the token that has balance, it could be great for UX. But we should keep a simple way with a flag to actually chose the token to use if specified by the user. |
|
@lambda-0x if you still want to tackle this, with the |
|
Simplified in #2650. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.