Remove hard-coded pkidbuser #4973
Merged
+56
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pkidbuser is mainly used by PKI in IPA to access DS using client cert auth. Regular (non-IPA) PKI generally do not use this user but currently the user is created by default during installation and the username is hard-coded in PKI. To simplify the installation the code that sets up the database user has been consolidated into configuration.py and the default pki_share_dbuser_dn has been removed so it will no longer create the user by default. IPA defines the pki_share_dbuser_dn during installation so it will not be affected by this change. The non-IPA tests have been updated to no longer check pkidbuser. There are still some references to pkidbuser in CertFixCLI (which is mainly used by IPA). They will be cleaned up separately later.
|
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pkidbuseris mainly used by PKI in IPA to access DS using client cert auth. Regular (non-IPA) PKI generally do not use this user but currently the user is created by default during installation and the username is hard-coded in PKI.To simplify the installation the code that sets up the database user has been consolidated into
configuration.pyand the defaultpki_share_dbuser_dnhas been removed so it will no longer create the user by default. IPA defines thepki_share_dbuser_dnduring installation so it will not be affected by this change.The non-IPA tests have been updated to no longer check
pkidbuser.There are still some references to
pkidbuserinCertFixCLI(which is mainly used by IPA). They will be cleaned up separately later.