Replace tpsclient with pki tps-client #4969
Conversation
Most of the code in tpsclient has been moved into libpki-tps.so (i.e. reverting commit 65d1a36) such that it can be reused by other tools. The main() function itself has been moved into tpsclient.cpp.
The pki tps-client has been added to replace tpsclient to make it easier to maintain TPS client code and to troubleshoot TPS issues. Currently it will simply reuse libpki-tps.so but in the future the native code will gradually be converted to Java. The tpsclient has been deprecated and will be removed in the future. The basic TPS test has been updated to test both pki tps-client and tpsclient.
|
| /** | ||
| * @author Endi S. Dewata | ||
| */ | ||
| public class TPSClientCLI extends CommandCLI { |
There was a problem hiding this comment.
TO be more in line with the other commands I think we should have tps-client-format and tps-client-enroll eliminating the need for the 2 additional scripts but this change can go in future PRs.
There was a problem hiding this comment.
Yes, that's the plan, but it will require some additional native -> Java conversion. We can add that later.
|
|
||
| /* Shutdown NSS and NSPR */ | ||
| NSS_Shutdown (); | ||
| PR_Cleanup (); |
There was a problem hiding this comment.
Initialisation is done in CryptoManger during CLI initialisation but shutdown/cleanup is not present (at least I have not found). I guess there should be no effect since after the operations the command will exit.
There was a problem hiding this comment.
Right, so far pki CLI is working just fine without it, but we can add it if necessary.
|
@fmarco76 Thanks! |
Most of the code in
tpsclienthas been moved intolibpki-tps.so(i.e. reverting commit 65d1a36) such that it can be reused by other tools. Themain()function itself has been moved intotpsclient.cpp.The
pki tps-clienthas been added to replacetpsclientto make it easier to maintain TPS client code and to troubleshoot TPS issues. Currently it will simply reuselibpki-tps.sobut in the future the native code will gradually be converted to Java.The
tpsclienthas been deprecated and will be removed in the future.The basic TPS test has been updated to test both
pki tps-clientandtpsclient./~https://github.com/edewata/pki/blob/tpsclient/docs/changes/v11.7.0/Tools-Changes.adoc