Add test for ACME container with CA #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new test has been added to create a CA container and an ACME container using the CA, then run ACME tests using certbot. The pki-acme-run script has been modified to create the /conf/acme folder to store imported config files if it doesn't exist already. The pki-server-run script has been modified to create an NSS database and the /conf/certs folder to store imported certs if they don't exist already. The pki-server run command has been modified to provide options to skip config upgrade and migration. The pki-server-run script has also been modified to use these options since in general containers should not alter the config files automatically (including creating backup files). For now containers should assume that the config files are already upgraded/migrated by the admin. The tests for basic ACME container and PKI server container have been updated to no longer expect a backup folder to be created in the /logs folder.
|
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new test has been added to create a CA container and an ACME container using the CA, then run ACME tests using
certbot.The
pki-acme-runscript has been modified to create the/conf/acmefolder to store imported config files if it doesn't exist already.The
pki-server-runscript has been modified to create an NSS database and the/conf/certsfolder to store imported certs if they don't exist already.The
pki-server runcommand has been modified to provide options to skip config upgrade and migration. Thepki-server-runscript has also been modified to use these options since in general containers should not alter the config files automatically (including creating backup files). For now containers should assume that the config files are already upgraded/migrated by the admin.The tests for basic ACME container and PKI server container have been updated to no longer expect a
backupfolder to be created in the/logsfolder.