-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[add-ascii-string-blameable] Allow ascii_string to validTypes #2802
[add-ascii-string-blameable] Allow ascii_string to validTypes #2802
Conversation
The issue |
Are there other extensions it'd make sense to add |
I hadn't thought of that, but I'll have a look. So I'm closing this pull-request and I'll open another if need be? |
You can add more changes to this PR by committing to the same branch. |
Done, i found two other class who can need this modification IpTraceable and Sluggable. |
@mbabker when it can be test then release ? |
e1f9be8
to
4c412e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2802 +/- ##
==========================================
- Coverage 78.75% 78.35% -0.40%
==========================================
Files 163 167 +4
Lines 8593 8598 +5
==========================================
- Hits 6767 6737 -30
- Misses 1826 1861 +35 ☔ View full report in Codecov by Sentry. |
thanks @Nirator78! |
Update Gedmo\Blameable\Mapping\Driver\Annotation::validTypes to allow ascii_string.
This is my first contribution to an open source project. Thank you in advance for guiding me through the process.