Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add-ascii-string-blameable] Allow ascii_string to validTypes #2802

Merged

Conversation

Nirator78
Copy link
Contributor

Update Gedmo\Blameable\Mapping\Driver\Annotation::validTypes to allow ascii_string.
This is my first contribution to an open source project. Thank you in advance for guiding me through the process.

@Nirator78
Copy link
Contributor Author

The issue
#2802

@mbabker
Copy link
Contributor

mbabker commented May 23, 2024

Are there other extensions it'd make sense to add ascii_string support to as well? Might as well do it all in one go IMO.

@Nirator78
Copy link
Contributor Author

Are there other extensions it'd make sense to add ascii_string support to as well? Might as well do it all in one go IMO.

I hadn't thought of that, but I'll have a look. So I'm closing this pull-request and I'll open another if need be?

@mbabker
Copy link
Contributor

mbabker commented May 23, 2024

You can add more changes to this PR by committing to the same branch.

@Nirator78
Copy link
Contributor Author

You can add more changes to this PR by committing to the same branch.

Done, i found two other class who can need this modification IpTraceable and Sluggable.

@Nirator78
Copy link
Contributor Author

@mbabker when it can be test then release ?

@franmomu franmomu force-pushed the add-ascii-string-blameable branch from e1f9be8 to 4c412e3 Compare June 9, 2024 06:24
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (0632ab1) to head (4c412e3).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2802      +/-   ##
==========================================
- Coverage   78.75%   78.35%   -0.40%     
==========================================
  Files         163      167       +4     
  Lines        8593     8598       +5     
==========================================
- Hits         6767     6737      -30     
- Misses       1826     1861      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franmomu franmomu merged commit d98fbd4 into doctrine-extensions:main Jun 9, 2024
17 of 18 checks passed
@franmomu
Copy link
Collaborator

franmomu commented Jun 9, 2024

thanks @Nirator78!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants