Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. code doc updates #2773

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Feb 19, 2024

Just as advertised:

  • Updates the trait doc blocks to remove references to PHP 5.4, we're a bit past that point 😉
  • Updates the marker interface doc blocks to make it a bit more clear these are generic marker interfaces
  • Updates the inline comments on the marker interfaces to stop using a very legacy annotation syntax

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0632ab1) 78.75% compared to head (a45b8e8) 78.91%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
+ Coverage   78.75%   78.91%   +0.16%     
==========================================
  Files         163      163              
  Lines        8593     8502      -91     
==========================================
- Hits         6767     6709      -58     
+ Misses       1826     1793      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franmomu franmomu merged commit 8d658b4 into doctrine-extensions:main Feb 19, 2024
18 checks passed
@franmomu
Copy link
Collaborator

thanks @mbabker, nice work!

@mbabker mbabker deleted the docs-updates branch February 19, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants