feat: allow friendsofphp/php-cs-fixer >= 3.10

[Chris53897]

bump "rector/rector" to 0.17

is the upper constraint for friendsofphp/php-cs-fixer still in need?

On local development, this blocks doctrine/annotations v2.
The CI removes it before running the tests.
/~https://github.com/doctrine-extensions/DoctrineExtensions/blob/main/.github/workflows/continuous-integration.yml#L65

[phansys]

I'm fine allowing higher versions of friendsofphp/php-cs-fixer as long the considerations mentioned at #2507 regarding the phpdoc_order rule are covered.

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2d327ad) 79.36% compared to head (84eced7) 79.39%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2626      +/-   ##
==========================================
+ Coverage   79.36%   79.39%   +0.02%     
==========================================
  Files         162      162              
  Lines        8457     8454       -3     
==========================================
  Hits         6712     6712              
+ Misses       1745     1742       -3     

Files	Coverage Δ
src/AbstractTrackingListener.php	94.54% <ø> (ø)
src/Blameable/Mapping/Driver/Annotation.php	80.00% <100.00%> (ø)
src/Blameable/Traits/BlameableDocument.php	0.00% <ø> (ø)
src/Blameable/Traits/BlameableEntity.php	100.00% <ø> (ø)
src/IpTraceable/Mapping/Driver/Annotation.php	77.77% <100.00%> (ø)
src/IpTraceable/Traits/IpTraceableDocument.php	0.00% <ø> (ø)
src/IpTraceable/Traits/IpTraceableEntity.php	100.00% <ø> (ø)
src/Loggable/LoggableListener.php	92.74% <ø> (ø)
src/Mapping/Annotation/Blameable.php	100.00% <ø> (ø)
src/Mapping/Annotation/IpTraceable.php	35.71% <ø> (ø)
... and 48 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Chris53897]

Ok i see a lot of default rules changed. I had the same problem at another repo.

Can you please decide how you want this configs to be set.
phpdoc_separation
global_namespace_import @var \DateTime|null vs @var DateTime|null

I have added no_superfluous_phpdoc_tags => false, because it would otherwise remove useful phpdocs (in my point of view).
Additional i have added a composer-script to check it locally (dry-run same as in ci) to make it easier to check it local.

I run it locally on php 8.2. Looks like the default is correct followed

'phpdoc_order' => [
                'order' => [
                    'param',
                    'return',
                    'throws',
                ],
            ],

[franmomu]

Can you please decide how you want this configs to be set. phpdoc_separation global_namespace_import @var \DateTime|null vs @var DateTime|null

Now I see this, I think we can use for phpdoc_separation:

'phpdoc_separation' => ['groups' => [
            ['Gedmo\\*'],
            ['ODM\\*'],
            ['ORM\\*'],
        ]],

global_namespace_import I would leave it like @var \DateTime|null which is what we have now.

I have added no_superfluous_phpdoc_tags => false, because it would otherwise remove useful phpdocs (in my point of view). Additional i have added a composer-script to check it locally (dry-run same as in ci) to make it easier to check it local.

I run it locally on php 8.2. Looks like the default is correct followed

'phpdoc_order' => [
                'order' => [
                    'param',
                    'return',
                    'throws',
                ],
            ],

About the order, we have now ['param', 'throws', 'return'] which was the default order, I think @phansys meant to keep it

[Chris53897]

Anything todo for me here?

[phansys]

Anything todo for me here?

No @Chris53897, thank you.
I'll be waiting for the @franmomu's review.

[franmomu]

Thanks @Chris53897! and @phansys for reviewing!