Ability to overwrite an existing manifest #1282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "ability-to-overwrite-an-existing-manifest" git@github.com:dims/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Sometimes amend is not enough, especially when `--purge` was not used during `manifest push` command. And since we don't have a `manifest delete` either to clean up. So just adding an `--overwrite` seems like a good thought. Change-Id: I473952ae434f421b6345c28db5cfdfcc49614710 Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
ability-to-overwrite-an-existing-manifest
branch
from
52c7a52 to
b3d79ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
==========================================
- Coverage 54.29% 54.29% -0.01%
==========================================
Files 268 268
Lines 17855 17859 +4
==========================================
+ Hits 9695 9696 +1
- Misses 7550 7551 +1
- Partials 610 612 +2 |
|
@vdemeester can you looks this one? Would be good to have this in-place before merging #1355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Sometimes amend is not enough, especially when
--purgewasnot used during
manifest pushcommand. And since we don't have amanifest deleteeither to clean up. So just adding an--overwriteseems like a good thought.
- How I did it
Added a
--overwritein command/manifest/create_list.go- How to verify it
create and push a manifest, then try to create the same manifest with --overwrite. It used to fail before, with this new option, it should succeed.
- Description for the changelog
Ability to overwrite an existing manifest in
docker manifest create- A picture of a cute animal (not mandatory but encouraged)