This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Clean path before validating app #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use filepath.Clean() to clean the path arg in docker app validate so that the path is correctly tested on both Unix and Windows machines. Signed-off-by: Nick Adcock <nick.adcock@docker.com>
eunomie
approved these changes
Nov 26, 2019
rumpl
approved these changes
Nov 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
==========================================
- Coverage 69.66% 69.63% -0.04%
==========================================
Files 64 64
Lines 3597 3567 -30
==========================================
- Hits 2506 2484 -22
+ Misses 760 756 -4
+ Partials 331 327 -4
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Clean the App name while getting the directory path so that pathing works with trailing slashes on both Unix and Windows machines
- How I did it
Use filepath.Clean() to clean the path arg in docker app validate so that the path is correctly tested on both Unix and Windows machines.
- How to verify it
On Windows run
.\bin\docker-app-windows.exe app validate .\examples\cnab-simple\hello.dockerapp\The command should succeed
- Description for the changelog
docker app validatewill no longer fail on Windows when the supplied App path has a trailing backslash- A picture of a cute animal (not mandatory)