Merge pull request #728 from zappy-shu/dont-show-id-as-repository

Don't show ID as repository in image ls
docker · Nov 7, 2019 · 71ad534 · 71ad534
2 parents 8acd0a8 + c19f7d4
commit 71ad534
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/internal/commands/image/list.go b/internal/commands/image/list.go
@@ -148,7 +148,7 @@ func getImageListColumns(options imageListOption) []imageListColumn {
 			if n, ok := p.ref.(reference.Named); ok {
 				return reference.FamiliarName(n)
 			}
-			return reference.FamiliarString(p.ref)
+			return "<none>"
 		}},
 		{"TAG", func(p pkg) string {
 			if t, ok := p.ref.(reference.Tagged); ok {

diff --git a/internal/commands/image/list_test.go b/internal/commands/image/list_test.go
@@ -75,19 +75,19 @@ func TestListCmd(t *testing.T) {
 	}{
 		{
 			name: "TestList",
-			expectedOutput: `REPOSITORY                                                       TAG    APP IMAGE ID APP NAME
-foo/bar                                                          <none> 3f825b2d0657 Digested App
-foo/bar                                                          1.0    9aae408ee04f Foo App
-a855ac937f2ed375ba4396bbc49c4093e124da933acd2713fb9bc17d7562a087 <none> a855ac937f2e Quiet App
+			expectedOutput: `REPOSITORY TAG    APP IMAGE ID APP NAME
+foo/bar    <none> 3f825b2d0657 Digested App
+foo/bar    1.0    9aae408ee04f Foo App
+<none>     <none> a855ac937f2e Quiet App
 `,
 			options: imageListOption{},
 		},
 		{
 			name: "TestListWithDigests",
-			expectedOutput: `REPOSITORY                                                       TAG    DIGEST                                                                  APP IMAGE ID APP NAME
-foo/bar                                                          <none> sha256:b59492bb814012ca3d2ce0b6728242d96b4af41687cc82166a4b5d7f2d9fb865 3f825b2d0657 Digested App
-foo/bar                                                          1.0    <none>                                                                  9aae408ee04f Foo App
-a855ac937f2ed375ba4396bbc49c4093e124da933acd2713fb9bc17d7562a087 <none> sha256:a855ac937f2ed375ba4396bbc49c4093e124da933acd2713fb9bc17d7562a087 a855ac937f2e Quiet App
+			expectedOutput: `REPOSITORY TAG    DIGEST                                                                  APP IMAGE ID APP NAME
+foo/bar    <none> sha256:b59492bb814012ca3d2ce0b6728242d96b4af41687cc82166a4b5d7f2d9fb865 3f825b2d0657 Digested App
+foo/bar    1.0    <none>                                                                  9aae408ee04f Foo App
+<none>     <none> sha256:a855ac937f2ed375ba4396bbc49c4093e124da933acd2713fb9bc17d7562a087 a855ac937f2e Quiet App
 `,
 			options: imageListOption{digests: true},
 		},