This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 532
[FIX] Update BERTLayerNorm Implementation #485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxjscience
approved these changes
Dec 27, 2018
Job PR-485/3 is complete. |
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 71.02% 71.46% +0.43%
==========================================
Files 119 118 -1
Lines 10045 9937 -108
==========================================
- Hits 7134 7101 -33
+ Misses 2911 2836 -75
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 71.02% 71.46% +0.43%
==========================================
Files 119 118 -1
Lines 10045 9937 -108
==========================================
- Hits 7134 7101 -33
+ Misses 2911 2836 -75
|
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 71.02% 71.46% +0.43%
==========================================
Files 119 118 -1
Lines 10045 9937 -108
==========================================
- Hits 7134 7101 -33
+ Misses 2911 2836 -75
|
szha
approved these changes
Dec 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming that the specialized layer norm block is for extension purpose
paperplanet
pushed a commit
to paperplanet/gluon-nlp
that referenced
this pull request
Jun 9, 2019
* fix layer norm * fix indentation * fix lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
apache/mxnet#13732
There was a typo in the
nn.LayerNorm
documentation. It turns out that we can safely reusenn.LayerNorm
which is faster than the implementation in GluonNLP.As a sanity check, I run
compare_tf_gluon_model.py
again withbert_24_1024_16/bert_12_768_12
onbook_corpus_wiki_en_uncased/book_corpus_wiki_en_cased
and the test passes.@fierceX @haven-jeon
Checklist
Essentials