Support std::exception in threadediter #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anirudh2290 Is this still needed? |
|
@hcho3 sorry i missed your comment on this. this is still needed. |
|
ping @hcho3 |
|
ping @tqchen can you please help review and merge this. |
hcho3
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for std::exception in threadediter. This will catch std::exceptions and opencv exceptions and fail gracefully instead of terminating the process.
This also fixes apache/mxnet#10393
Fixes: apache/mxnet#12280, although this is closed this issue is not yet fixed
@zhreshold @hcho3