Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Foreman 3.9 and newer #27

Merged
merged 1 commit into from
May 7, 2024
Merged

Support Foreman 3.9 and newer #27

merged 1 commit into from
May 7, 2024

Conversation

laugmanuel
Copy link
Member

  • migrate to settings DSL
  • drop old Foreman version support
  • switch to upstream CI
  • switch to upstream rubocop

@laugmanuel laugmanuel mentioned this pull request May 6, 2024
Closed
@laugmanuel laugmanuel force-pushed the feat/support-latest-foreman branch 9 times, most recently from f1037a7 to c649b61 Compare May 6, 2024 12:16
@laugmanuel laugmanuel mentioned this pull request May 6, 2024
Closed
@laugmanuel laugmanuel marked this pull request as ready for review May 6, 2024 12:22
@laugmanuel
Copy link
Member Author

Do you mind having a look @archanaserver ?

@laugmanuel laugmanuel requested a review from ochnerd May 6, 2024 12:23
ekohl
ekohl reviewed May 6, 2024
View reviewed changes
Rakefile Outdated Show resolved Hide resolved
lib/tasks/foreman_rescue_tasks.rake Show resolved Hide resolved
lib/tasks/foreman_rescue_tasks.rake Outdated Show resolved Hide resolved
locale/gemspec.rb Outdated Show resolved Hide resolved
test/lib/tasks/seeds_test.rb Show resolved Hide resolved
app/models/setting/rescue.rb Outdated Show resolved Hide resolved
app/models/setting/rescue.rb Outdated Show resolved Hide resolved
lib/foreman_rescue/engine.rb Show resolved Hide resolved
@laugmanuel laugmanuel force-pushed the feat/support-latest-foreman branch from c649b61 to e1302cc Compare May 6, 2024 14:45
@laugmanuel
Support Foreman 3.9 and newer
3d0dd40 
- migrate to settings DSL
- drop old Foreman version support
- switch to upstream CI
- switch to upstream rubocop
- migrate access permission tests
@laugmanuel laugmanuel force-pushed the feat/support-latest-foreman branch from e1302cc to 3d0dd40 Compare May 6, 2024 14:54
@laugmanuel laugmanuel merged commit 3beefb8 into master May 7, 2024
46 checks passed
@laugmanuel
Copy link
Member Author

Thanks for the review @ekohl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@ochnerd ochnerd Awaiting requested review from ochnerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laugmanuel @ekohl