Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated or inaccurate interfaces in the app sdk #7403

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

FsFsmk
Copy link
Contributor

@FsFsmk FsFsmk commented Feb 20, 2025

No description provided.

@FsFsmk FsFsmk requested a review from a team as a code owner February 20, 2025 21:19
@FsFsmk FsFsmk requested review from colinloretz and removed request for a team February 20, 2025 21:19
Copy link

@brad-discord brad-discord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with this space, but I do have some questions.

| application? | [MessageApplication](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/messageapplication) \| null |
| message_reference? | [MessageReference](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/messagereference) \| null |
| flags? | number |
| stickers? | Sticker[] \| null |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of your change, but should Sticker be a link to another part of the docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is an api message object, stickers is deprecated and only present on old messages, and new messages use the sticker_items field

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is yeah, i think the maintainers of the SDK forgot to add sticker_items since it is not present

Comment on lines 1365 to 1364
| mention_channels? | [ChannelMention](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/channelmention)[] |
| attachments | [Attachment](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/attachment)[] |
| embeds | [Embed](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/embed)[] |
| reactions? | [Reaction](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/reaction)[] |
| nonce? | string |
| pinned | boolean |
| webhook_id? | string |
| type | number |
| activity? | [MessageActivity](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/messageactivity) |
| application? | [MessageApplication](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/messageapplication) |
| message_reference? | [MessageReference](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/messagereference) |
| flags? | number |
| stickers? | Sticker[] |
| referenced_message? | [Message](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/message) |
| Property | Type |
|---------------------|-----------------------------------------------------------------------------------------|
| id | string |
| channel_id | string |
| guild_id? | string \| null |
| author? | [User](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/user) \| null |
| member? | [GuildMember](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/guildmember) \| null |
| content | string |
| timestamp | string |
| edited_timestamp? | string \| null |
| tts | boolean |
| mention_everyone | boolean |
| mentions | [User](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/user)[] |
| mention_roles | string[] |
| mention_channels | [ChannelMention](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/channelmention)[] |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting - what happened to make mention_channels no longer optional in this context? It looks like it's optional on the Message resource

Copy link
Contributor Author

@FsFsmk FsFsmk Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either the sdk or Message resource are wrong, I directly checked the sdk's code

@brad-discord
Copy link

Please npm run fix:tables to pass our formatting check. 🙏

Copy link

@brad-discord brad-discord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for the contribution!

@colinloretz colinloretz merged commit 565efb3 into discord:main Feb 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants