add handling for notFound status list

digitalcredentials · Jan 19, 2025 · 37e4fbb · 37e4fbb
1 parent 8fde1f0
commit 37e4fbb
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 9 deletions.
diff --git a/src/Verify.ts b/src/Verify.ts
@@ -39,14 +39,16 @@ const suite = [ed25519Suite, eddsaSuite]
     checkStatus
   });
 
+  processAnyStatusError({verificationResponse, statusResult: verificationResponse.statusResult});
+
   // remove things we don't need from the result or that are duplicated elsewhere
   delete verificationResponse.results
   delete verificationResponse.statusResult
   delete verificationResponse.verified
-
-  verificationResponse.isFatal = false
   verificationResponse.credential = credential
 
+  verificationResponse.isFatal = false
+
   if (verificationResponse.error) {
     if (verificationResponse.error.log) {
       // move the log out of the error to the response, since it
@@ -74,7 +76,7 @@ const suite = [ed25519Suite, eddsaSuite]
 }
 
 function buildFatalErrorObject(fatalErrorMessage: string, name: string, credential: Credential, stackTrace: string | null): VerificationResponse {
-  return { credential, isFatal: true, errors: [{ name, message: fatalErrorMessage, isFatal: true, ...stackTrace ? { stackTrace } : null }] }
+  return { credential, isFatal: true, errors: [{ name, message: fatalErrorMessage, ...stackTrace ? { stackTrace } : null }] }
 }
 
 function checkForFatalErrors(credential: Credential): VerificationResponse | null {
@@ -114,6 +116,22 @@ function checkForFatalErrors(credential: Credential): VerificationResponse | nul
   return null
 }
 
+function processAnyStatusError( {verificationResponse, statusResult} :{
+  verificationResponse: VerificationResponse,
+  statusResult: any
+}) : void
+ {
+  if (statusResult?.error?.cause?.message?.startsWith('NotFoundError')) {
+    const statusStep = {
+      "id": "revocation_status",
+      "error": {
+        name: 'status_list_not_found',
+        message: statusResult.error.cause.message 
+      }
+  };
+    (verificationResponse.log ??= []).push(statusStep)
+  }
+}
 
 // import { purposes } from '@digitalcredentials/jsonld-signatures';
 // import { VerifiablePresentation, PresentationError } from './types/presentation';

diff --git a/src/test-fixtures/expectedResults.ts b/src/test-fixtures/expectedResults.ts
@@ -33,8 +33,7 @@ const expectedResult = {
     errors: [
       {
         name: 'error name goes here, e.g., no_proof',
-        message: 'error message goes here',
-        isFatal: true
+        message: 'error message goes here'
       }
     ]
   }

diff --git a/src/types/result.ts b/src/types/result.ts
@@ -1,16 +1,16 @@
 
 export interface VerificationError {								
     "message": string,
-    "isFatal": boolean,
     "name"?: string,
-    stackTrace?: string
+    "stackTrace"?: string
   }
 
   export interface VerificationStep {
     "id": string,
-    "valid": boolean,
+    "valid"?: boolean,
     "foundInRegistries"?: string[],
-    "registriesNotLoaded"?: RegistriesNotLoaded[]
+    "registriesNotLoaded"?: RegistriesNotLoaded[],
+    "error"?: VerificationError
   }
 
   export interface VerificationResponse {