Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Don't display has_many as an attribute. #2585

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

przprz
Copy link
Contributor

@przprz przprz commented Nov 30, 2020

The docs reads

//! You can declare an association between two records with `#[belongs_to]`.
//! Unlike other ORMs, Diesel has no concept of `#[has_many`]

If there's no has many in Diesel, why use the argument syntax here?
I found it a little bit confusing when reading for the first time.

@weiznich
Copy link
Member

Filled rust-lang/rust#79560 for the nightly failure (it's a upstream rustc bug)

@weiznich weiznich merged commit daf1d33 into diesel-rs:master Nov 30, 2020
@przprz przprz deleted the minor-doc-improvement-has_many branch November 30, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants