Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #180

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Update PR template #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@
<!-- _Link to github issue(s)_ -->

### PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

> - Open new test/doc issues under the [devfile/api](/~https://github.com/devfile/api/issues) repo
> - Check each criteria if:
> - There is a separate tracking issue. Add the issue link under the criteria
> **or**
> - test/doc updates are made as part of this PR
> - If unchecked, explain why it's not needed
<!--
- Open new test/doc issues under the [devfile/api](/~https://github.com/devfile/api/issues) repo
- Check each criteria if:
- There is a separate tracking issue. Add the issue link under the criteria
**or**
- test/doc updates are made as part of this PR
- If unchecked, explain why it's not needed
-->


- [ ] Unit/Functional tests
Expand All @@ -23,9 +25,9 @@ Testing and documentation do not need to be complete in order for this PR to be

<!-- _Do we need to verify integration with ODO and Openshift console?_ -->

- [ ] Documentation
- [ ] Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

<!-- _This includes product docs and READMEs._ -->
<!-- _This includes READMEs, Product Docs, Blogs, Education Modules, etc._ -->

- [ ] Client Impact

Expand Down