test: successful login with weak or strong password #9858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9858 +/- ##
==========================================
- Coverage 54.71% 50.69% -4.02%
==========================================
Files 1261 938 -323
Lines 155988 126646 -29342
Branches 3590 3605 +15
==========================================
- Hits 85342 64204 -21138
+ Misses 70514 62311 -8203
+ Partials 132 131 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
maxrussell
approved these changes
Aug 22, 2024
| }); | ||
| }); | ||
|
|
||
| it('logs in with weak password', async () => { |
There was a problem hiding this comment.
Nit: more descriptive description can make it easier/quicker to diagnose CI failures.
Suggested change
| it('logs in with weak password', async () => { | |
| it('logs in with warning when using a weak password', async () => { |
EmilyBonar
approved these changes
Aug 26, 2024
Comment on lines
+50
to
+56
| await waitFor(() => { | ||
| // onFinish begins: | ||
| expect(screen.getByRole('button')).toBeDisabled(); | ||
| }); | ||
| await waitFor(() => { | ||
| // onFinish ends: | ||
| expect(screen.getByRole('button')).not.toBeDisabled(); |
There was a problem hiding this comment.
nit: this part isn't in the weak password test, it should probably be in both or neither
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CM-432
Description
Add unit testing to
DeterminedAuthto test:Test Plan
No additional testing required, unit test should pass.
Checklist
docs/release-notes/See Release Note for details.