Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add release notes for 0.36.0 #9854

Merged
merged 14 commits into from
Aug 23, 2024
Merged

Conversation

corban-beaird
Copy link
Contributor

Add release notes for 0.36.0.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Aug 21, 2024
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.71%. Comparing base (9332ab9) to head (2e02f3d).
Report is 5 commits behind head on release-0.36.0.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-0.36.0    #9854      +/-   ##
==================================================
- Coverage           54.93%   54.71%   -0.22%     
==================================================
  Files                 846     1261     +415     
  Lines               82471   155964   +73493     
  Branches                0     3587    +3587     
==================================================
+ Hits                45305    85341   +40036     
- Misses              37166    70491   +33325     
- Partials                0      132     +132     
Flag Coverage Δ
backend 45.17% <ø> (+<0.01%) ⬆️
harness 72.61% <ø> (ø)
web 54.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 419 files with indirect coverage changes

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style guide applied.

Version 0.36.0
==============

**Release Date:** August 22, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

August 23rd? (hopeful)


**New Features**

- WebUI: In the enterprise edition of Determined, when RBAC is enabled, allow only Viewer, Editor,
Copy link

@caehd10 caehd10 Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does allow "only" mean here should it just be "allow"? @tara-det-ai @corban-beaird

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

its scope. However, the ``EditorProjectRestricted`` role lacks the permissions to create or
update projects.

- Kubernetes: Add experimental support for AMD ROCM GPUs. To use, set ``slotType=rocm``. Visit
Copy link

@caehd10 caehd10 Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is spelled ROCm, not ROCM (obviously only update description here, not the slotType parameter value)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thanks

- Kubernetes: Add experimental support for AMD ROCM GPUs. To use, set ``slotType=rocm``. Visit
:ref:`helm-config-reference` for more details.

- Images: Add New ROCM 6.1 images with DeepSpeed for MI300x users. Dev versions of these images can
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - ROCm

**Bug Fixes**

- Experiments: Report an experiment's status as FAILED if any failure occurs during the shutdown
process, before the experiment has completed gracefully.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight nit: Instead of gracefully, do we mean successfully? @corban-beaird @tara-det-ai defer to you on wording but I am confused what that means

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bug fix note is for #9693

This wording accurately reflects the distinction between a successful, orderly shutdown and a failure that prevents it. "successful + orderly" = "graceful".


- Like the ``Editor`` role, the ``EditorProjectRestricted`` role grants the permissions to
create, edit, or delete experiments and NSC (Notebook, Shell or Command) type workloads within
its scope. However, the ``EditorProjectRestricted`` role lacks the permissions to create or
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be more direct here by what we mean within its scope --> don't we mean "within the project"? I would just overly clarify the exact behavior is reading this RBAC stuff for the first time can lead to confusion for users

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not within the project, this is within whatever the Editor is scoped to which could be one or more workspaces or globally so within its scope is right. Maybe we could add in brackets something like ...within its scope (workspace(s) or global)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its probably redundant but maybe we can be explicit here and say "read, create, edit or delete experiments...". Don't think it's a big deal since I dont think its possible to have a situation where you can edit but not read

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree the rbac roles are very difficult to decipher in sentence format, particularly when we start saying this role supercedes this role, this role precedes this role.... i have a docs ticket to better describe these and help users (and us) visualize them. we can even make a flowchart pictogram if needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the suggested change has been added

docs/release-notes.rst Outdated Show resolved Hide resolved
docs/release-notes.rst Outdated Show resolved Hide resolved
docs/release-notes.rst Outdated Show resolved Hide resolved
docs/release-notes.rst Outdated Show resolved Hide resolved
@determined-ci determined-ci requested a review from a team August 23, 2024 15:18
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Co-authored-by: Tara <tara.charter@hpe.com>
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Co-authored-by: Tara <tara.charter@hpe.com>
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Co-authored-by: Tara <tara.charter@hpe.com>
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Co-authored-by: Tara <tara.charter@hpe.com>
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@corban-beaird corban-beaird requested a review from caehd10 August 23, 2024 15:53
@corban-beaird corban-beaird assigned caehd10 and unassigned hkumar92 Aug 23, 2024
Co-authored-by: Tara <tara.charter@hpe.com>
@determined-ci determined-ci requested a review from a team August 23, 2024 16:08
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@corban-beaird corban-beaird merged commit 39db2a8 into release-0.36.0 Aug 23, 2024
71 of 94 checks passed
@corban-beaird corban-beaird deleted the relnotes-0.36.0 branch August 23, 2024 21:13
determined-ci pushed a commit that referenced this pull request Aug 23, 2024
Co-authored-by: Tara Charter <tara.charter@hpe.com>
(cherry picked from commit 39db2a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants