-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add release notes for 0.36.0 #9854
Conversation
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0.36.0 #9854 +/- ##
==================================================
- Coverage 54.93% 54.71% -0.22%
==================================================
Files 846 1261 +415
Lines 82471 155964 +73493
Branches 0 3587 +3587
==================================================
+ Hits 45305 85341 +40036
- Misses 37166 70491 +33325
- Partials 0 132 +132
Flags with carried forward coverage won't be shown. Click here to find out more. |
Docsite preview being generated for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style guide applied.
docs/release-notes.rst
Outdated
Version 0.36.0 | ||
============== | ||
|
||
**Release Date:** August 22, 2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
August 23rd? (hopeful)
docs/release-notes.rst
Outdated
|
||
**New Features** | ||
|
||
- WebUI: In the enterprise edition of Determined, when RBAC is enabled, allow only Viewer, Editor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does allow "only" mean here should it just be "allow"? @tara-det-ai @corban-beaird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
docs/release-notes.rst
Outdated
its scope. However, the ``EditorProjectRestricted`` role lacks the permissions to create or | ||
update projects. | ||
|
||
- Kubernetes: Add experimental support for AMD ROCM GPUs. To use, set ``slotType=rocm``. Visit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is spelled ROCm, not ROCM (obviously only update description here, not the slotType parameter value)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes thanks
docs/release-notes.rst
Outdated
- Kubernetes: Add experimental support for AMD ROCM GPUs. To use, set ``slotType=rocm``. Visit | ||
:ref:`helm-config-reference` for more details. | ||
|
||
- Images: Add New ROCM 6.1 images with DeepSpeed for MI300x users. Dev versions of these images can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here - ROCm
**Bug Fixes** | ||
|
||
- Experiments: Report an experiment's status as FAILED if any failure occurs during the shutdown | ||
process, before the experiment has completed gracefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight nit: Instead of gracefully, do we mean successfully? @corban-beaird @tara-det-ai defer to you on wording but I am confused what that means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this bug fix note is for #9693
This wording accurately reflects the distinction between a successful, orderly shutdown and a failure that prevents it. "successful + orderly" = "graceful".
docs/release-notes.rst
Outdated
|
||
- Like the ``Editor`` role, the ``EditorProjectRestricted`` role grants the permissions to | ||
create, edit, or delete experiments and NSC (Notebook, Shell or Command) type workloads within | ||
its scope. However, the ``EditorProjectRestricted`` role lacks the permissions to create or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be more direct here by what we mean within its scope --> don't we mean "within the project"? I would just overly clarify the exact behavior is reading this RBAC stuff for the first time can lead to confusion for users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not within the project, this is within whatever the Editor is scoped to which could be one or more workspaces or globally so within its scope is right. Maybe we could add in brackets something like ...within its scope (workspace(s) or global)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its probably redundant but maybe we can be explicit here and say "read, create, edit or delete experiments...". Don't think it's a big deal since I dont think its possible to have a situation where you can edit but not read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree the rbac roles are very difficult to decipher in sentence format, particularly when we start saying this role supercedes this role, this role precedes this role.... i have a docs ticket to better describe these and help users (and us) visualize them. we can even make a flowchart pictogram if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the suggested change has been added
Docsite preview being generated for this PR. |
Co-authored-by: Tara <tara.charter@hpe.com>
Docsite preview being generated for this PR. |
Co-authored-by: Tara <tara.charter@hpe.com>
Docsite preview being generated for this PR. |
Co-authored-by: Tara <tara.charter@hpe.com>
Docsite preview being generated for this PR. |
Co-authored-by: Tara <tara.charter@hpe.com>
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Co-authored-by: Tara <tara.charter@hpe.com>
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Co-authored-by: Tara Charter <tara.charter@hpe.com> (cherry picked from commit 39db2a8)
Add release notes for 0.36.0.