Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't ignore failed exps #9693

Merged
merged 9 commits into from
Aug 13, 2024

edit

0db6296
Select commit
Loading
Failed to load commit list.
Merged

fix: don't ignore failed exps #9693

edit
0db6296
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 13, 2024 in 0s

54.27% (-0.03%) compared to 79ffa52

View this Pull Request on Codecov

54.27% (-0.03%) compared to 79ffa52

Details

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.27%. Comparing base (79ffa52) to head (0db6296).
Report is 1 commits behind head on main.

Files Patch % Lines
master/internal/experiment.go 20.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9693      +/-   ##
==========================================
- Coverage   54.29%   54.27%   -0.03%     
==========================================
  Files        1261     1261              
  Lines      155642   155646       +4     
  Branches     3536     3536              
==========================================
- Hits        84510    84473      -37     
- Misses      70994    71035      +41     
  Partials      138      138
Files Coverage Δ
master/internal/experiment.go 30.21% <20.00%> (-0.18%) ⬇️

... and 7 files with indirect coverage changes

View more details on Codecov