Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add master config option to provide custom logo #9664

Merged
merged 26 commits into from
Jul 31, 2024

fmt docs

fc7a289
Select commit
Loading
Failed to load commit list.
Merged

feat: add master config option to provide custom logo #9664

fmt docs
fc7a289
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 31, 2024 in 1s

54.15% (+0.00%) compared to dab6978

View this Pull Request on Codecov

54.15% (+0.00%) compared to dab6978

Details

Codecov Report

Attention: Patch coverage is 40.00000% with 51 lines in your changes missing coverage. Please review.

Project coverage is 54.15%. Comparing base (dab6978) to head (fc7a289).

Files Patch % Lines
master/internal/config/ui_config.go 70.45% 13 Missing ⚠️
webui/react/src/components/Logo.tsx 0.00% 12 Missing ⚠️
webui/react/src/components/PageMessage.tsx 0.00% 7 Missing ⚠️
master/internal/core.go 0.00% 6 Missing ⚠️
webui/react/src/routes/utils.ts 14.28% 6 Missing ⚠️
webui/react/src/pages/SignIn.tsx 0.00% 5 Missing ⚠️
master/internal/api_master.go 0.00% 1 Missing ⚠️
webui/react/src/services/decoder.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9664   +/-   ##
=======================================
  Coverage   54.15%   54.15%           
=======================================
  Files        1258     1259    +1     
  Lines      154990   155064   +74     
  Branches     3500     3501    +1     
=======================================
+ Hits        83937    83978   +41     
- Misses      70907    70940   +33     
  Partials      146      146           
Files Coverage Δ
master/internal/config/config.go 69.86% <ø> (ø)
webui/react/src/stores/determinedInfo.tsx 86.45% <100.00%> (+0.28%) ⬆️
master/internal/api_master.go 2.34% <0.00%> (-0.02%) ⬇️
webui/react/src/services/decoder.ts 21.53% <0.00%> (-0.03%) ⬇️
webui/react/src/pages/SignIn.tsx 0.00% <0.00%> (ø)
master/internal/core.go 6.24% <0.00%> (-0.05%) ⬇️
webui/react/src/routes/utils.ts 65.23% <14.28%> (-1.44%) ⬇️
webui/react/src/components/PageMessage.tsx 0.00% <0.00%> (ø)
webui/react/src/components/Logo.tsx 0.00% <0.00%> (ø)
master/internal/config/ui_config.go 70.45% <70.45%> (ø)

... and 2 files with indirect coverage changes