This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
[rector] Add defluent set #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
rector-defluent
branch
from
560b28a to
2a445d4
Compare
TomasVotruba
commented
Oct 18, 2020
| @@ -33,10 +33,6 @@ parameters: | |||
| ignoreErrors: | |||
| - '#Method App\\Form\\ProjectFormType\:\:buildForm\(\) has parameter \$formBuilder with no value type specified in iterable type Symfony\\Component\\Form\\FormBuilderInterface#' | |||
|
|
|||
| # no idea how to fix these now, possible sources: /~https://github.com/phpstan/phpstan-doctrine/blob/e560d32f6fb68e5bbec0e556a69723e7faece14a/tests/Rules/Doctrine/ORM/data/EntityWithRelations.php | |||
| - '#Method (.*?) return type with generic interface Doctrine\\Common\\Collections\\Collection does not specify its types\: TKey, T#' | |||
| - '#Property (.*?) with generic interface Doctrine\\Common\\Collections\\Collection does not specify its types\: TKey, T#' | |||
There was a problem hiding this comment.
@Kerrialn FIY, I took a Sunday off and made a Rector rule to handle these :)
See rectorphp/rector#4442 (comment)
It's part of SetList::DOCTRINE_CODE_QUALITY set
TomasVotruba
force-pushed
the
rector-defluent
branch
from
24cb02c to
2f833ee
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.