Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach generated_pr_notices into the PR description #10399

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Aug 10, 2024

What are you trying to accomplish?

Implementing a feature to attach generated PR notices into the PR description. This includes using log levels to match messages shown on the UI, ensuring clear communication of deprecation and other important information.

What issues does this affect or fix?

This PR adds the generated bundler v1 deprecation warning into alongside with other generated PR notices into PR description.

Anything you want to highlight for special attention from reviewers?

  • This PR introduces a generic method to provide informational messages, warnings, and errors in the PR description. Currently, it is used to show bundler v1 deprecation warning in this PR but can also be used to show other kinds of information, warnings, and errors.

How will you know you've accomplished your goal?

  • Demonstration: The deprecation alert and other generated PR notices should appear in the PR description as intended.
Screenshot 2024-08-07 at 9 56 18 AM

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1
Copy link
Contributor Author

kbukum1 commented Aug 16, 2024

The feature implemented in the following PR, #10421

@kbukum1 kbukum1 closed this Aug 16, 2024
@kbukum1 kbukum1 deleted the kamil/attaching_generated_pr_notices_into_pr_description branch August 22, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant