only certain types of pr changes

delta-io · Oct 9, 2024 · 6b2ce4b · 6b2ce4b
1 parent e6242a1
commit 6b2ce4b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/semver-checks.yml b/.github/workflows/semver-checks.yml
@@ -1,6 +1,13 @@
 name: semver-checks
 
-on: [pull_request_target]
+# Trigger when a PR is opened or changed
+on:
+  pull_request_target:
+    types:
+      - opened
+      - edited
+      - synchronize
+      - reopened
 
 env:
   CARGO_TERM_COLOR: always
@@ -10,6 +17,7 @@ jobs:
   check_if_pr_breaks_semver:
     runs-on: ubuntu-latest
     permissions:
+      contents: read
       pull-requests: write
     steps:
       - uses: actions/checkout@v4

diff --git a/kernel/src/engine/default/parquet.rs b/kernel/src/engine/default/parquet.rs
@@ -36,7 +36,7 @@ impl<E: TaskExecutor> DefaultParquetHandler<E> {
     /// Max number of batches to read ahead while executing [Self::read_parquet_files()].
     ///
     /// Defaults to 10.
-    pub fn with_readahead_x(mut self, readahead: usize) -> Self {
+    pub fn with_readahead(mut self, readahead: usize) -> Self {
         self.readahead = readahead;
         self
     }