Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI 1.6 support #16

Merged
merged 3 commits into from
Nov 9, 2023
Merged

CSI 1.6 support #16

merged 3 commits into from
Nov 9, 2023

Conversation

adarsh-dell
Copy link

@adarsh-dell adarsh-dell commented Oct 9, 2023 •
edited
Loading

Description

CSI Spec v1.6 support

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#905

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Imported the latest commit in CSI-PowerStore driver and can see MaximumVolumeSize and other required fields are present that is in CSI spec v1.6 feature.

@adarsh-dell adarsh-dell marked this pull request as ready for review October 19, 2023 09:32
rajkumar-palani
rajkumar-palani approved these changes Nov 7, 2023
View reviewed changes
Copy link

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adarsh-dell adarsh-dell merged commit 1340f73 into main Nov 9, 2023
@kumarkgosa kumarkgosa deleted the release-1.9.0 branch November 4, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@mdutka-dell mdutka-dell mdutka-dell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adarsh-dell @rajkumar-palani @nitesh3108 @HarishH-DELL @mdutka-dell